359331 - modutil -changepw strict shutdown failure

Status: RESOLVED FIXED

(NSS :: Tools, defect, P2)

Description

[Nelson Bolyard (seldom reads bugmail)]

Let $FIPS be the name of a directory containing an NSS DB file trio 
configured to run in FIPS mode.

When environment variable NSS_STRICT_SHUTDOWN is set to 1,  the command 
   modutil.exe -dbdir $FIPS -changepw "NSS FIPS 140-2 Certificate DB"
crashes in NSS_Shutdown due to a reference leak.

This bug was formerly recorded as a comment in bug 354423.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

I filed this as a "tools" bug, assuming that the bug is in the modutil program.
If the bug is found to be in the NSS libraries, please change this to a 
libraries bug.

Comment 2

[Alexei Volkov]

Attachment: destroy slot before calling NSS_Shutdown

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 245249 [details] [diff] [review]
destroy slot before calling NSS_Shutdown

r=nelson
Alexei, 
Please combine this patch with the patch for bug 354423, which also patches this same function in cmd/modutil/pk11.c, and do one checkin that fixes both bugs.  Thanks.

Comment 4

[Alexei Volkov]

/cvsroot/mozilla/security/nss/cmd/modutil/pk11.c,v  <--  pk11.c
new revision: 1.25; previous revision: 1.24
/cvsroot/mozilla/security/nss/cmd/tests/remtest.c,v  <--  remtest.c
new revision: 1.4; previous revision: 1.3