360028 - Bugzilla::Search::Saved should have create() and update(), and buglist.cgi should use it

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, enhancement)

Description

[Max Kanat-Alexander]

The next step in creating saved reports is that the Saved Search object needs to be able to update the database.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Okay, I did test this a bit.

Comment 2

[Max Kanat-Alexander]

Just to make it clear, this is a blocker because it blocks a blocker.

Comment 3

[Frédéric Buclin]

Comment on attachment 245062 [details] [diff] [review]
v1

>Index: Bugzilla/Search/Saved.pm

>+use Bugzilla::Util;

You also have to add |use Bugzilla::Error;| here, else Bugzilla crashes everytime a validator wants to throw an error (such as when entering an invalid query name).

r=LpSolit with this comment fixed.

Comment 4

[Dave Miller [:justdave]]

Don't forget to fix the item in comment 3 before checkin.

Comment 5

[Max Kanat-Alexander]

Search::Saved appears twice because I did the checkin fix after the original checkin, by mistake.

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.347; previous revision: 1.346
done
Checking in Bugzilla/CGI.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/CGI.pm,v  <--  CGI.pm
new revision: 1.31; previous revision: 1.30
done
Checking in Bugzilla/Constants.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Constants.pm,v  <--  Constants.pm
new revision: 1.60; previous revision: 1.59
done
Checking in Bugzilla/Search/Saved.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search/Saved.pm,v  <--  Saved.pm
new revision: 1.2; previous revision: 1.1
done

Checking in Bugzilla/Search/Saved.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search/Saved.pm,v  <--  Saved.pm
new revision: 1.3; previous revision: 1.2
done