Closed Bug 360528 Opened 18 years ago Closed 18 years ago

Can no longer import trusted email cert

Categories

(Core :: Security: PSM, defect, P1)

Product:
Core
Component:
Security: PSM
Version:
1.8 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: KaiE, Assigned: KaiE)

References

Details

(Keywords: regression, verified1.8.1.2)

Attachments

(1 file)

Patch v1
953 bytes, patch
rrelyea
: review+
wtc
: review+
jay
: approval1.8.1.2+
Details | Diff | Splinter Review 
We introduced a regression with bug 310446.

The regression causes us to fail importing email certs.
Keywords: regression
Priority: -- → P1
Attached patch Patch v1 — — Splinter Review 

        Attachment #245431 -
        Flags: review?(rrelyea)

    
  
Blocks: 354525

    
    

    
  
Kai, you also need to do something about
  CERTCertificateListCleaner chainCleaner(certChain);
which is now initialized with certChain=nsnull.  There are
two instances of chainCleaner.

    
    

    
  
I see that CERTCertificateListCleaner takes a reference of its
argument, so the code is correct.  Please ignore my previous comment.

    
    

    
  
Comment on attachment 245431 [details] [diff] [review]
Patch v1

r+ = relyea.

        Attachment #245431 -
        Flags: review?(rrelyea) → review+

    
    

    
  
fixed on trunk.

Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 245431 [details] [diff] [review]
Patch v1

We should get this regression fix into Thunderbird 2.

Not sure whether to ask for approval1.8.1.1 or approval1.8.1.2

        Attachment #245431 -
        Flags: approval1.8.1.2?

        Attachment #245431 -
        Flags: approval1.8.1.1?

    
    

    
  
Kai:  We are done with 1.8.1.1, so nominating for 1.8.1.2.  Also cc'ing mscott so this bug doesn't get lost for Thunderbird 2 (since there is no flag for it here).
Flags: wanted1.8.1.x+
Flags: blocking1.8.1.2?

    
  

        Attachment #245431 -
        Flags: approval1.8.1.1?

    
  
Flags: blocking1.8.1.2? → blocking1.8.1.2+

    
    

    
  
Comment on attachment 245431 [details] [diff] [review]
Patch v1

Approved for 1.8 branch, a=jay for drivers.

        Attachment #245431 -
        Flags: approval1.8.1.2? → approval1.8.1.2+

    
    

    
  
Comment on attachment 245431 [details] [diff] [review]
Patch v1

r=wtc.

        Attachment #245431 -
        Flags: review+

    
    

    
  
I checked in the patch on the MOZILLA_1_8_BRANCH.
Keywords: fixed1.8.1.2

    
    

    
  
Verified fixed for 1.8.1.2 with Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.2pre) Gecko/20070104 Thunderbird/2.0b1 Mnenhy/0.7.4.10002 and my personal  thawte email cert. 
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1.2 → verified1.8.1.2

    
    

    
  
What presently-released versions of FF 2 (if any) contain this fix?

    
    

    
  
Nelson, 1.8.1.2 is equivalent to Firefox 2.0.0.2, which was the first version that contains the fix.


          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: