360708 - Commenter's IP is hidden by caching proxy

Status: RESOLVED INVALID

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Giorgio Maone [:ma1]]

AMO records commenter's IP, probably to easily spot duplicate comments or returning shrills/trolls.
Unluckily a side effect of the proxy cache is hiding this info: all the comments appear to come from 10.2.81.4.

Comment 2

[Justin Scott [:fligtar]]

Moving to Public Pages as that is where reviews originate. I think this is still a problem in Remora. (Also occurs with download logging)

Comment 3

[Fred Wenzel [:wenzel]]

Does the Netscaler pass on the original user's IP in a request header? If not, can we make it?

If it can't, this is a classical "CANTFIX" I'd say. But if we can get the cache to pass it on to the app server, we should put some magic into place to fish the right IP out of the request.

CCing mrz because he knows how the Netscalers roll.

Comment 4

[Reed Loden [:reed]]

(In reply to comment #3)
> Does the Netscaler pass on the original user's IP in a request header? If not,
> can we make it?

HTTP_X_FORWARDED_FOR, iirc.

Comment 5

[matthew zeier [:mrz]]

(In reply to comment #3)
> Does the Netscaler pass on the original user's IP in a request header? If not,
> can we make it?

Client IP is passed along as X-Forwarded-For.

Comment 6

[Michael Morgan [:morgamic]]

This isn't an issue anymore.