360839 - Expose pref for saving session state

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Stuart Morgan]

Once we do something sane in the crash case (bug 358689), we need a GUI pref for automagic session save/restore (camino.remember_window_state).

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We'll need to do this before b1 if it's to make 1.1.

Comment 2

[Chris Lawson (gone)]

Per IRC, blocking b1.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Ian and I discussed some wording along the lines of

When Camino opens: [x] Restore the pages I was viewing when I quit

The wording's not great yet, but I think that's a viable ballpark.  The thing we have to be very careful about is length; we can't make the left side much longer than it already is in General, but we also need the right side to not be too long.

Comment 4

[froodian (Ian Leue)]

Another thing we have to think about is making it clear that having this pref on stomps the "homepage in new window" pref when launching the app (unless we decide that that's a bug and change that).

Comment 5

[Stuart Morgan]

(In reply to comment #4)
> Another thing we have to think about is making it clear that having this pref
> on stomps the "homepage in new window" pref when launching the app

I don't follow; what pref is this, and how is it stomped?

Comment 6

[froodian (Ian Leue)]

Attachment: Patch

Comment 7

[froodian (Ian Leue)]

Attachment: New Navigation.nib

This uses the string in comment 3 (and should therefore probably get textual polish).

Comment 8

[Chris Lawson (gone)]

Comment on attachment 252946 [details] [diff] [review]
Patch

r=me pending a successful test by Smokey of both code and nib changes.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 252947 [details]
New Navigation.nib

r=ardissone, but please make the min height = current height on checkin

Anyone have any better ideas for the text?  It's OK, but it doesn't sound quite as polished as our usual efforts ;)

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

cl suggested 

When Camino opens: [x] Load the pages I was viewing when I quit

which keeps the same verbs as the other prefs there, and sounds better (as well as removes ambiguity of "restore", since we don't actually restore page state, scroll position, DHTML, etc.).  

We'd both prefer something that removed the first person there, if possible.

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

When opening Camino: [x] Load the pages from the last time it was open

When Camino starts: [x] Load the pages that were open before quitting


Ian thinks the latter is the best suggestion so far.

Comment 12

[Stuart Morgan]

Comment on attachment 252946 [details] [diff] [review]
Patch

sr=smorgan with:
When Camino starts: [x] Load the pages that were open before quitting

Comment 13

[froodian (Ian Leue)]

Checked in on trunk and MOZILLA_1_8_BRANCH with new text (comment 12) and min height fix (comment 9)