361624 - user style sheets may not be imported from Safari

Status: RESOLVED FIXED

(Firefox :: Migration, defect)

Description

[(not reading, please use [e-mail] instead)]

user style sheets may not imported from Safari

the problem is an inititialized variable, which could also hork bug #344284

from my build:

/Users/sspitzer/Desktop/trunk/mozilla/browser/components/migration/src/nsSafariProfileMigrator.cpp:
In member function 'nsresult
nsSafariProfileMigrator::ParseBookmarksFolder(const __CFArray*,
nsIRDFResource*, nsIBookmarksService*, PRBool)':
/Users/sspitzer/Desktop/trunk/mozilla/browser/components/migration/src/nsSafariProfileMigrator.cpp:996:
warning: 'rv' may be used uninitialized in this function

if I initialize rv to anything other than NS_OK (a.k.a. 0, see http://lxr.mozilla.org/seamonkey/source/xpcom/base/nsError.h#159), then CopyBookmarks() will fail, and we will never call CopyFormData() or CopyOtherData(), and CopyOtherData() is what migrates the user style sheets.

elaborate steps to reproduce coming next!

Comment 1

[(not reading, please use [e-mail] instead)]

elaborate steps to reproduce:

1) set up a userContent.css in safari (see attachment #1 [details] [diff] [review]).  put it in ~/Library/Safari/userContent.css (the one I attached will disable the blink tag)
2) verify that safari no longer blinks (see attachment #2 [details] [diff] [review] in safari)
3) make sure that firefox blinks (see attachment #2 [details] [diff] [review] in firefox)
4) import data from safari, including "other data" (see attachment #3 [details] [diff] [review])
5) restart Firefox and make sure that we imported userContent.css and make sure that firefox no longer blinks

when I forced import to fail, I got this on my console:

JavaScript error: , line 0: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIBrowserProfileMigrator.migrate]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://browser/content/migration/migration.js :: anonymous :: line 390"  data: no]

I initialized rv to NS_ERROR_FAILURE.  the fix is to initialize to NS_OK.

note, I am not certain what rv is going to be initialized too, so reproducing this (to verify the fix) may not be easy.

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: attachment #1 (userContent.css)

Comment 3

[(not reading, please use [e-mail] instead)]

Attachment: attachment #2 (html with blink tag)

Comment 4

[(not reading, please use [e-mail] instead)]

Attachment: attachment #3 (import from safari)

Comment 5

[(not reading, please use [e-mail] instead)]

Attachment: attachment #4 (setting up safari to use userContent.css)

Comment 6

[(not reading, please use [e-mail] instead)]

Attachment: patch to initialize rv (and fix another PLACES warning I created)

this has r=gavin over email

Comment 7

[(not reading, please use [e-mail] instead)]

fixed on the trunk.

Checking in nsOperaProfileMigrator.cpp;
/cvsroot/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp,v  <--  nsOperaProfileMigrator.cpp
new revision: 1.58; previous revision: 1.57
done
Checking in nsSafariProfileMigrator.cpp;
/cvsroot/mozilla/browser/components/migration/src/nsSafariProfileMigrator.cpp,v  <--  nsSafariProfileMigrator.cpp
new revision: 1.33; previous revision: 1.32
done