361791 - Unnecessary signed-unsigned casts, warnings in xpidl_util.c

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Jeff Walden [:Waldo]]

Portions of UUIDs are being sscanf'd as unsigned numbers but are being stuffed into signed ones for no reason.  This also necessitated some casting when those signed numbers were stuffed into the unsigned fields of an nsID, again for no good reason.  The to-be-posted patch makes the values into which numbers are stuffed unsigned to ease compiler warnings.

We could go even further and make n1 and n2 PRUint16 and n3[8] PRUint8, but then we'd have to use different format specifiers, which is non-trivial without C99's SCNx32, SCNx16, and SCNx8 macros (or requires using PR_sscanf, but I can't find docs on the NSPR integer format specifiers, other than that there's an unspecified mapping between sscanf and PR_sscanf specifiers).

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Patch

Comment 2

[Jeff Walden [:Waldo]]

(In reply to comment #0)
> PR_sscanf

So as it turns out, I was blind and missed the specifier docs, but it's irrelevant because xpidl explicitly doesn't depend on NSPR and thus isn't usable.

Comment 3

[Jeff Walden [:Waldo]]

Fixed.