Closed Bug 361875 Opened 18 years ago Closed 18 years ago

Use of uninitialized value in numeric eq (==) at Bugzilla/User.pm line 1465

Categories

(Bugzilla :: Email Notifications, defect)

2.23.3
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 3.0

People

(Reporter: LpSolit, Assigned: LpSolit)

References

Details

(Keywords: regression)

Attachments

(1 file)

sub wants_mail {

    # Skip DB query if relationship is explicit
    return 1 if $relationship == REL_GLOBAL_WATCHER;
    
    my $dbh = Bugzilla->dbh;
    
    # If a relationship isn't given, default to REL_ANY.
    if (!defined($relationship)) {
        $relationship = REL_ANY;
    }


We should first set $relationship to REL_ANY if it's undefined, then check if its value is REL_GLOBAL_WATCHER.
Attached patch patch, v1Splinter Review
Attachment #246612 - Flags: review?(bugzilla-mozilla)
Attachment #246612 - Flags: review?(bugzilla-mozilla) → review+
Status: NEW → ASSIGNED
Flags: approval?
Flags: approval? → approval+
Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.143; previous revision: 1.142
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: