36188 - Quoted message has extra line breaks in html format

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Craig Ewert]

I replied to a message, quoted same, and used text & html for reply format. The 
quoted message was double spaced in the html part of the multipart message.
This was on the 2000041712 build on Win98.

Looking at the raw html, the problem is: the quoted messages is surrounded by 
<pre></pre> tags, AND has <br> at the end of each line. Should lose the <br>s

Comment 1

[Craig Ewert]

Attachment: this is the html part of the newgroup message.

Comment 2

[Craig Ewert]

Sorry for the scatter; this is my first bug report. This is the ID of the 
message with the error: [e-mail]. Its dated April 17, 2000 
in n.p.m.ui on news.mozilla.org. The subject is "Re: Mozilla skin cleanup 
proposal".

Comment 3

[Akkana Peck]

I think this is my bug -- the formatting code that inserts newlines needs to
detect that it's not inside a pre tag.  It makes life pretty annoying for both
plaintext and html mail (replies come out double-spaced), so I'm also marking
this beta2.

Comment 4

[Akkana Peck]

M16 -- this needs to be fixed asap since it's a dogfood issue.

QA: to test this, send yourself a plaintext message that says:

one
two
three

When the message arrives, reply to it in html compose.  Send it without further
editing.  (Do this once sending as html, again sending as plaintext -- both
modes have problems, but should probably be tested separately since they go
through different code paths.)  When the reply arrives, there should be no extra
blank lines between the "one", "two" and "three" lines.

Comment 5

[Akkana Peck]

Just checked in a fix for this.  This should fix both plaintext and html.

Comment 6

[fenella]

Linux (2000-04-21-08 M16)
Win32 (2000-04-21-09 M16)
Mac (2000-04-21-08 M16)
I followed Akkana's instruction, compose a message in Plain text and reply it in
both plain text and Html. No extra blank line is inserted between the line. 

Akkana, I retested it, and only found that one extra line is inserted after the
end of the quated text on all 3 platforms. So that is acceptable.