Closed Bug 362067 Opened 18 years ago Closed 18 years ago

Tab groups in bookmark menus need alternates

Categories

(Camino Graveyard :: Toolbars & Menus, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Camino1.5

People

(Reporter: froodian, Assigned: froodian)

Details

(Keywords: fixed1.8.1.1)

Attachments

(1 file)

Bug 350806 Comment 3:

> > Groups should have menu alternates too.  I guess that was missed in the other
> > bug?  I'm not sure what extra plumbing would be needed if any to support it in
> > the opening logic; if it's as easy as adding a call to your new method here,
> > lets do it now, otherwise we'll need a follow-up bug.
>
> Yeah, we just missed this in the original bug.  Done.

This got lost somewhere in the debitrotting.
Attached patch PatchSplinter Review
Attachment #246766 - Flags: review?(mozilla)
Comment on attachment 246766 [details] [diff] [review]
Patch

codewise r=me
Attachment #246766 - Flags: review?(mozilla) → review+
Attachment #246766 - Flags: superreview?(stuart.morgan)
Comment on attachment 246766 [details] [diff] [review]
Patch

sr=smorgan
Attachment #246766 - Flags: superreview?(stuart.morgan) → superreview+
Checked in on 1.8branch and trunk.
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
Keywords: fixed1.8fixed1.8.1.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: