Closed Bug 362265 Opened 18 years ago Closed 18 years ago

Some packages are registering PACKAGE instead of CONTENT

Categories

(SeaMonkey :: Installer, defect)

Product:
SeaMonkey
Component:
Installer
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

Details

(Keywords: fixed-seamonkey1.1)

Attachments

(1 file)

Proposed patch
15.88 KB, patch
ajschult784
: review+
dveditz
: superreview+
kairo
: approval-seamonkey1.1+
Details | Diff | Splinter Review 
PACKAGE = CONTENT | SKIN | LOCALE so it should only be used if one contents.rdf file describes all three types of resources. However our .jar files contain one contents.rdf for each resource and they are all separately registered.
Attached patch Proposed patch — — Splinter Review 
Assignee: xpi-packages → neil
Status: NEW → ASSIGNED

        Attachment #246966 -
        Flags: review?(ajschult)

    
    

    
  
Comment on attachment 246966 [details] [diff] [review]
Proposed patch

right.  Someone was actually complaining this week in #seamonkey that those lines were missing from the .zip build's installed-chrome.txt.  :)

note that build/ and mac/ are obsolete...

        Attachment #246966 -
        Flags: review?(ajschult) → review+

    
  

        Attachment #246966 -
        Flags: superreview?(dveditz)

    
    

    
  
Comment on attachment 246966 [details] [diff] [review]
Proposed patch

sr=dveditz

        Attachment #246966 -
        Flags: superreview?(dveditz) → superreview+

    
    

    
  
Comment on attachment 246966 [details] [diff] [review]
Proposed patch

Dunno if this is branch-worthy.

        Attachment #246966 -
        Flags: approval-seamonkey1.1?

    
    

    
  
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 246966 [details] [diff] [review]
Proposed patch

first-a=me given that this has been on trunk for a week

    
    

    
  
Comment on attachment 246966 [details] [diff] [review]
Proposed patch

a=me for 1.1

        Attachment #246966 -
        Flags: approval-seamonkey1.1? → approval-seamonkey1.1+

    
    

    
  
Fix checked in to the branch.
Keywords: fixed-seamonkey1.1

    
  
Component: Installer: XPI Packages → Installer
QA Contact: general

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: