362293 - Consider adding context menus to nsPresContext::mActivePopups

Status: RESOLVED WONTFIX

(Core :: XUL, defect)

Description

[Mats Palmgren (inactive)]

This is a followup from bug 324963.

I think nsPopupSetFrame::ActivatePopup() might be the place to add the
calls (and possible remove the call in nsMenuPopupFrame::Destroy).
I think we have the frame we want in 'aEntry->mPopupFrame'.


Opening a context menu:

nsCSSFrameConstructor::AttributeChanged 02464DE0 popup menugenerated
[02290028]nsPopupSetFrame::ActivatePopup 1
  aEntry->mPopupContent=02464DE0 aEntry->mPopupFrame=02BE1528
nsCSSFrameConstructor::AttributeChanged 02464DE0 popup _moz-menuactive

Closing it:

[02290028]nsPopupSetFrame::ActivatePopup 0
nsCSSFrameConstructor::AttributeChanged 02464DE0 popup _moz-menuactive
nsMenuPopupFrame::Destroy 02BE1528 (pc=021E99F0)
[021E99F0]: PresContext: removing popup 02BE1528

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I think we should leave the Remove call in nsMenuPopupFrame::Destroy. That protects us from having dead frames in the array.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Hmm, but nsPopupSetFrame::ActivatePopup doesn't actually show the popup right away, that's asynchronous, right?

Comment 3

[Neil Deakin]

This code doesn't exist anymore with the popup reworking, so no need for this bug.