Closed Bug 363075 Opened 18 years ago Closed 17 years ago

Need project patch to dispose of non-virtual dtor warnings in prefpane targets

Categories

(Camino Graveyard :: General, defect)

Product:
Camino Graveyard
Component:
General
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
VERIFIED WORKSFORME

People

(Reporter: bugzilla-graveyard, Assigned: alqahira)

Details

I finally figured out how to get rid of them, so let's kill those little buggers.

Basically, I went through and added "-Wno-non-virtual-dtor" to the Build tab in all .mm files in each Preference Pane under the Targets section of the project. (You can select multiple .mm files at once to do that.)

Smokey, can you generate a project patch based on the above?

Mento, is that the right approach?
Is there a reason we wouldn't want to just add it to the target itself, rather than each file?
We turned that warning off globally before, in each build style, and when I look at each prefPane target, that setting is off.

Are you sure you're still seeing them?  If so, why aren't they inheriting that from the parent build styles?
I don't see these warnings in any of the tinderbox logs, either; --> WFM
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → WORKSFORME
Something along the line somewhere seems to have fixed this, yes. Verified. If it comes back and I can't get rid of it easily, I'll file a new bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.