363089 - Remove nsIDOMEventReceiver

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

After bug 363067, nsIDOMEventReceiver could be merged to nsPIDOMEventTarget.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Actually, nsIDOMEventReceiver can be just removed and use nsIEventListenerManager when really needed.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

WIP patch containing also bug 363067 is here http://www.cs.helsinki.fi/u/pettay/moztests/events/remove_nsidomeventreceiver.diff

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

http://www.cs.helsinki.fi/u/pettay/moztests/events/remove_nsidomeventreceiver.diff
should remove now all uses of nsIDOMEventReceiver.
And it even compiles (ff, tb, sm) :)

Waiting for bug 363067.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v1

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 262273 [details] [diff] [review]
v1

- In content/xbl/public/nsIXBLService.h:

-  NS_IMETHOD AttachGlobalKeyHandler(nsIDOMEventReceiver* aElement)=0;
+  NS_IMETHOD AttachGlobalKeyHandler(nsPIDOMEventTarget* aTarget)=0;

Since you're changing this "interface", you should bump the IID here (even if it's not in IDL). Same for nsPIDOMEventTarget.

- In embedding/browser/gtk/src/EmbedPrivate.h:

   EmbedContentListener          *mContentListener;
   nsCOMPtr<nsISupports>          mContentListenerGuard;
   EmbedEventListener            *mEventListener;
   nsCOMPtr<nsISupports>          mEventListenerGuard;
 
   nsCOMPtr<nsIWebNavigation>     mNavigation;
   nsCOMPtr<nsISHistory>          mSessionHistory;
 
-  // our event receiver
-  nsCOMPtr<nsIDOMEventReceiver>  mEventReceiver;
+  nsCOMPtr<nsPIDOMEventTarget>  mEventTarget;

Add a space to make member names line up again.

r+sr=jst with that.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

I'll check this in during next weekend, when there aren't too many
other check-ins.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

bah, I just checked this in. Hoping not to see to much red in tboxes.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

backed out. some chrome and mochitests failed and couldn't immediately see where to problem is.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Attachment: checked in

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

nsIDOMEventTarget occurs still few times in the tree, for example in
some comments. I'll post a small patch to remove those.

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Attachment: leftovers

Things which aren't usually (or ever) compiled.
The strange looking part is nsWindowRoot, but those macros don't
actually use the second parameter currently.

Comment 12

[Johnny Stenback (:jst)]

Comment on attachment 264801 [details] [diff] [review]
leftovers

r+sr=jst