363188 - When overwriting pre-filled username/password fields with new values, old values are re-remembered in PM

Status: VERIFIED WORKSFORME

(Toolkit :: Password Manager, defect)

Description

[Steve England [:stevee]]

This bug was found whilst testing 2.0.0.1 rc1 in the litmus test suite:
- http://litmus.mozilla.org/show_test.cgi?id=1847
- http://litmus.mozilla.org/show_test.cgi?id=1848

To save having to follow those repo steps, I present them here:

1. New profile, start firefox
2. Navigate to http://www.mozilla.org/quality/browser/front-end/testcases/wallet/login.html
3. Username: Squiddy (&) Password: calamari
4. Press the Login button
5. Click "Remember" to the "Do you want Firefox to remember this password?" dialog. (Press "Continue" on "information sent over unencrypted connection" warning)
6. You are taken to a 404:File Not Found page (expected)
7. Tools > Options > Security > Show Passwords. Note the site "http://www.mozilla.org" has a password remembered for used "Squiddy" (expected).
8. [Close] Password Manager Dialog, [Cancel] Options dialog.
9. Open http://www.mozilla.org/quality/browser/front-end/testcases/wallet/login.html in a new tab
10. Note the username/password fields are pre-filled with Username:Squiddy and Password:calamari (expected)
11. Double click on username field so "Squiddy" is highlighted, and overwrite the text with "foo"
12. Double click on password field so "********" is highlighted, and overwrite the text with "bar"
13. Click "Login"
14. Click "Remember" to the "Do you want Firefox to remember this password?" dialog.
15. You are taken to a 404:File Not Found page (expected)
16. Tools > Options > Security > Show Passwords

Expected:
Two entries in the password manager
- http://www.mozilla.org | foo | <bar>
- http://www.mozilla.org | Squiddy | <calamari>

Actual:
Three entries in the password manager
- http://www.mozilla.org | foo | <bar>
- http://www.mozilla.org | Squiddy | <calamari>
- http://www.mozilla.org | Squiddy | <calamari>
(Two instances of the Squiddy username)

So it seems that when the form is pre-filled with the initial Squiddy/calamari logon, and the user overwrites these username/password fields with foo/bar, submits, and chooses to remember the username/password, for some reason firefox also re-remembers the original username/password values that were overwritten.

This works as expected (only two site/username/password infos remembered) in:
- Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.0.8) Gecko/20061025 Firefox/1.5.0.8

This does not work as expected (three site/username/passowrd infos remembered; two entries duplicated) in:
- Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1) Gecko/2006102503 BonEcho/2.0
- Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.1) Gecko/2006120418 Firefox/2.0.0.1

Comment 1

[Jay Patel [:jay]]

stevee:  Do you have a regression range for this bug?

Comment 2

[Steve England [:stevee]]

Not yet, but I will go a-hunting.

Comment 3

[Tracy Walker [:tracy]]

some additional notes:

1) only happens with a fresh profile
2) only happens with the very first profile stored
3) only happens if the first and second password are remembered during the same browser session.
4) will happen even if the second password remembered is at another user/password field

Comment 4

[Tracy Walker [:tracy]]

sorry about the spam:

(In reply to comment #3)
> some additional notes:

> 2) only happens with the very first profile stored

should read:
2) only happens with the very first password stored

Comment 5

[Steve England [:stevee]]

Works as expected:
- Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1b1) Gecko/20060801 BonEcho/2.0b1 (2006080104)

Doesn't work as expected:
- Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1b1) Gecko/20060802 BonEcho/2.0b1 (2006080203)

Bonsai regression range:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=MOZILLA_1_8_BRANCH&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-08-01+03%3A00%3A00&maxdate=2006-08-02+04%3A00%3A00&cvsroot=%2Fcvsroot

Comment 6

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a6pre) Gecko/20070628 Minefield/3.0a6pre ID:2007062805
This WFM on trunk now.