363235 - [FIX]Regression with display of image placeholders when an invalid protocol is used

Status: VERIFIED FIXED

(Core :: Layout, defect, P1)

Description

[Martijn Wargers (dead)]

This bug was spun off from bug 307387.
See upcoming testcase.
When the img has a scr with an invalid protocl, the height and width of the placeholder becomes 0, even when a width and height is set in css.
This regressed on trunk between 2006-06-24 and 2006-06-27, I think it's a regression from bug 181860.

On 1.8.0.x/1.8.1 branch, I'm seeing a regression in that the first img in the testcase doesn't show up the alternate text anymore, this regressed on the 1.8.1 branch between 2006-07-04 and 2006-07-06, which coincides with the landing of the patch for bug 181860.

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

Sicking, how come nsNoDataProtocolContentPolicy uses REJECT_SERVER?  That's basically the return value that indicates content blocking is enabled for that site, so hide all traces of the image.  Don't you want REJECT_REQUEST?  That certainly fixes the issue on trunk for me...

Comment 3

[Daniel Veditz [:dveditz]]

Probably not a true blocker, but would be good to fix and may be easy

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 249072 [details] [diff] [review]
Fix

Thanks man

Comment 6

[Boris Zbarsky [:bzbarsky]]

Fixed.  Someone else may need to land this on branches...

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 249072 [details] [diff] [review]
Fix

This is very safe and fixes a regression from a security fix.

Comment 8

[Jay Patel [:jay]]

Comment on attachment 249072 [details] [diff] [review]
Fix

Approved for both branches, a=jay for drivers.

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in on branches

Comment 10

[Carsten Book [:Tomcat]]

Verified fixed on 1.8.1.2 and 1.8.0.10 with  Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.2pre) Gecko/2007011004 BonEcho/2.0.0.2pre and Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.0.10pre) Gecko/20070111 Firefox/1.5.0.10pre