363636 - duplicate nsLivemarkService.getSiteURI in toolbar.xml

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Robert Sayre]

this will avoid startup component instantiation

Comment 1

[Robert Sayre]

Attachment: copy it over (also avoids URI creation, since we just want the spec)

Comment 2

[(not reading, please use [e-mail] instead)]

Comment on attachment 248440 [details] [diff] [review]
copy it over (also avoids URI creation, since we just want the spec)

r=sspitzer

Comment 3

[Robert Sayre]

Attachment: add a comment in nsLivemarkService.js as suggested by sspitzer

Comment 4

[Robert Sayre]

Attachment: don't return on exception per gavin

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 248460 [details] [diff] [review]
don't return on exception per gavin

>Index: browser/components/places/content/toolbar.xml

>+                
>+                // duplicate nsLivemarkService.getSiteURI to avoid instantiating

>+                if (siteURIString) {            
>+                  button.setAttribute("siteURI", siteURIString);
>                 }

uber-nits: remove the whitespace on the blank line, and drop the brackets around the single-line else clause?

Comment 6

[Robert Sayre]

Attachment: nits fixed

Comment 7

[Robert Sayre]

Attachment: nits really fixed

Comment 8

[Robert Sayre]

Checking in toolkit/components/places/src/nsLivemarkService.js;
/cvsroot/mozilla/toolkit/components/places/src/nsLivemarkService.js,v  <--  nsLivemarkService.js
new revision: 1.5; previous revision: 1.4
done
Checking in browser/components/places/content/toolbar.xml;
/cvsroot/mozilla/browser/components/places/content/toolbar.xml,v  <--  toolbar.xml
new revision: 1.64; previous revision: 1.63
done

Comment 9

[(not reading, please use [e-mail] instead)]

for completeness:

hatted with sayrer over irc about this patch.

this patch duplicates some code in the livemarks service into the toolbar code, so that on start up, we don't have to instantiate the livemarks service (and do all the work it will do on instantiation.

note to qa, this is on all platforms, but you need --enable-places-bookmarks to test it.

Comment 10

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv