363910 - " Add a new query" should be renamed

Status: RESOLVED FIXED

(Bugzilla :: Whining, defect, P2)

Description

[timeless]

the button says "add a new query", but it's not creating a new query. it's adding an existing query to an existing whine.

that's very different

Comment 1

[timeless]

Attachment: include search

Comment 2

[Frédéric Buclin]

Comment on attachment 249576 [details] [diff] [review]
include search

>Index: template/en/default/whine/schedule.html.tmpl
>-        <input type="submit" value="Add a new query"
>+        <input type="submit" value="Include search"

This string appears elsewhere too, when you already have one query set. Both places must be fixed.

Comment 3

[timeless]

Attachment: both instances

Comment 4

[Frédéric Buclin]

I don't think "Include search" is better. Personally, I find it as confusing. The question which comes to mind is "which search"?

Comment 5

[Teemu Mannermaa (:wicked)]

Comment on attachment 274887 [details] [diff] [review]
both instances

Looks this bug was already partially fixed in bug 363912. But we now have a discrepancy between documentation and actual system. This discrepancy even affects some parts of the editwhines.cgi UI too! Not good. (Colin did say he didn't search for terms that were not changed.)

Term "query" needs to be changed in some other parts of editwhines.cgi page too. I count three places where the "query" word still appears in the introductory text and one in the "no searches available" text (line 330 of template/en/default/whine/schedule.html.tmpl).

I don't think term "Include search" is any better because it's now different from "Add a new event" and "Add a new schedule" terms. I would vote for using "Add a new search" everywhere, including docs.

>Index: docs/xml/using.xml
>===================================================================
>RCS file: /cvsroot/mozilla/webtools/bugzilla/docs/xml/using.xml,v
>retrieving revision 1.70
>diff -u -r1.70 docs/xml/using.xml

Funny, a diff header for a file that doesn't have any changes.

Comment 6

[Teemu Mannermaa (:wicked)]

Docs talk about buttons that are not available so something needs to done about this. Otherwise whine system UI is even more confusing to users than it already is. See also bug 287450.

Comment 7

[Max Kanat-Alexander]

trivial bugs aren't blockers. But yes, I agree that it would be nice to fix anything confusing about *any* part of Bugzilla's UI.

Comment 8

[Frédéric Buclin]

The Bugzilla 3.0 branch is now locked to security bugs and dataloss fixes only. This bug doesn't fit into one of these two categories and is retargetted to 3.2 as part of a mass-change. To catch bugmails related to this mass-change, use lts081207 in your email client filter.

Comment 9

[Frédéric Buclin]

Won't be taken for 3.2 either.

Comment 10

[Sunil Joshi [:sjoshi]]

Attachment: Patch

Comment 11

[Frédéric Buclin]

Comment on attachment 667982 [details] [diff] [review]
Patch

As wicked said in comment 5, you must also fix the text in the description at the top of the page as well as the name of the button in the documentation, see section 5.13.3.

Comment 12

[Sunil Joshi [:sjoshi]]

Attachment: Patch-v2

Fixed other areas of schedule.html.tmpl and in documentation too.

Comment 13

[Frédéric Buclin]

Comment on attachment 671222 [details] [diff] [review]
Patch-v2

Looks good. r=LpSolit

Comment 14

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified docs/en/xml/using.xml
modified template/en/default/whine/schedule.html.tmpl
Committed revision 8434.