364156 - Inefficient SQL: Selects versions one-by-one

Status: RESOLVED WORKSFORME

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Olav Vitters]

When viewing one bug, the following SQL statements are called.

SELECT value FROM versions
            WHERE product_id = '7'
SELECT versions.value, versions.product_id FROM versions
            WHERE value = '1.0.x'
            AND product_id = '7'
SELECT versions.value, versions.product_id FROM versions
            WHERE value = '1.2.x'
            AND product_id = '7'
(etc)

This should obviously be changed. Ideally to just:
SELECT versions.value, versions.product_id FROM versions WHERE product_id = '7'

For the bug I am testing this on, the product has 15 versions. At least 14
queries are thus avoidable.

For the whole SQL log, please see attachment 248929 [details].

Comment 1

[Max Kanat-Alexander]

If that takes more than 0.05 seconds, I'd be amazed. Using new_from_list would be good, and we plan to, but please understand that that would require actual enhancement, architecture-altering code, so I really need to see some *significant* profiling data for this.

Comment 2

[Olav Vitters]

Has since been fixed.