364510 - [FIX][reflow branch] Right hand side of empty select is slightly cut off

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Martijn Wargers (dead)]

See upcoming testcase, this regressed between 2006-12-07 and 2006-12-08, so probably a regression from the reflow branch landing.

As you know, I have 'fat' scrollbars.

I'll post screenshots of what I see with the testcase, before and after the reflow branch.

Also the right part of the select drop down arrow isn't repainted when a popup menu has been over it. It seems to only paint the 16px wide part that's the default size of the scrollbar, normally (and mine are 32px).

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Only the first select (the empty select) suffers from the "slightly cut off" part of the bug.
But both selects suffer from the painting bug when a popup menu has been over the right hand side of the selects.

Comment 2

[Martijn Wargers (dead)]

Attachment: Screenshots

Comment 3

[Boris Zbarsky [:bzbarsky]]

So the sizing issue here is that options have padding.  So when we have an option we end up with a total width of padding plus width of the scrollbar.

When we do _not_ have an option, we end up with a total width equal to the scrollbar... but we're trying to fit in the scrollbar width _and_ a nonbreaking space in there.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: This should fix it

Comment 5

[Martijn Wargers (dead)]

+  // of our display fram plus a scrollbar.  This can happen, eg, if the
Small spelling error: fram should be frame.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 252007 [details] [diff] [review]
This should fix it

s/fram /frame /

r+sr=dbaron

Comment 7

[Boris Zbarsky [:bzbarsky]]

Fixed.  not sure how to test it...