365236 - Implement font-size-adjust on Mac

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I'll attach the patch in Jan. 2007.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0.1

updating to latest trunk.

Vlad:

This patch doesn't changes the font selection. This patch only changes the font size if font-size-adjust is not 'none'. Would you review it?

Comment 3

[philippe (part-time)]

I tested this patch a bit. All of Hixies tests pass [1], except the last one [2]: I get a 3px by 3px square in Minefield Mac. Fx 2.0.0.1 Windows shows a 50px by 50px square, with a 10px border on my system. But I'm not sure that test is displayed correctly on FX 2.0.0.1 Windows either.

[1] there is the problem with line-height, though (bug 366138).
[2] http://www.hixie.ch/tests/adhoc/css/fonts/size-adjust/009.xml

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #3)
> [2]: I get a 3px by 3px square in Minefield Mac. Fx 2.0.0.1 Windows shows a
> 50px by 50px square, with a 10px border on my system. But I'm not sure that
> test is displayed correctly on FX 2.0.0.1 Windows either.
> 
> [2] http://www.hixie.ch/tests/adhoc/css/fonts/size-adjust/009.xml

Thank you for your testing. It may be reproduced on Win and Linux too. I read the code for calculating the height/width. The nsFont is referenced in the calculating. But current thebes doesn't change the size of nsFont. So, we need to change it, but it's another bug.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in.

Comment 6

[philippe (part-time)]

Thanks, Masayuki.

I filed bug 369083 for comment 3 and 4 (box width/height/border-width).

-----------
Verified with Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a2pre) Gecko/20070202 Minefield/3.0a2pre ID:2007020203 [cairo]