365320 - Adding a patch when filing a bug prevents filling in a requestee (e.g. for review?)

Status: VERIFIED FIXED

(bugzilla.mozilla.org :: General, defect, P1)

Description

[Olav Vitters]

To reproduce:
1. Go to https://bugzilla.mozilla.org/enter_bug.cgi?product=Bugzilla
2. Select a component (important!). If a component is already set, select another one.
3. Click add an attachment
4 [review]. Change review to ?
5. Try to fill in a requestee.

Step 5 fails if you've selected a (different) component.

Comment 1

[Frédéric Buclin]

Confirming! Probably it displays the requestee field, but then forgets to remove the "disabled" bit on it.

Comment 2

[Reed Loden [:reed]]

Need to replace lines 125-127 of template/en/default/bug/create/create.html.tmpl with:
                // Also hide the requestee field, if it exists.
                inputElement = document.getElementById("requestee_type-" + id).style;
                if (inputElement) inputElement.display = "none";

Comment 3

[Frédéric Buclin]

(In reply to comment #2)
> Need to replace lines 125-127 of
> template/en/default/bug/create/create.html.tmpl with:
>                 // Also hide the requestee field, if it exists.
>                 inputElement = document.getElementById("requestee_type-" +
> id).style;
>                 if (inputElement) inputElement.display = "none";
> 

This looks incorrect to me. If the requestee field doesn't exist, then document.getElementById() is undefined and so you cannot consider its 'style' attribute. You probably have to write:

  inputElement = document.getElementById("requestee_type-" + id);
  if (inputElement) inputElement.style.display = "none";

Comment 4

[Reed Loden [:reed]]

You're correct... I hadn't tested it yet (was in the progress of testing).

Should be:
                // Also hide the requestee field, if it exists.
                inputElement = document.getElementById("requestee_type-" + id);
                if (inputElement) inputElement.style.display = "none";

Comment 5

[Reed Loden [:reed]]

Attachment: patch - v1

This should fix it.

Comment 6

[Frédéric Buclin]

justdave, could you fix this bug on b.m.o? That's pretty irritating as you have to go back to the attachment page to set the requestee correctly.

Comment 7

[Dave Miller [:justdave]]

Patch applied in production.

Comment 8

[Frédéric Buclin]

Doesn't work at all. Now no requestee field is displayed at all.

Comment 9

[Dave Miller [:justdave]]

OK fixed for real now.  There were some inconsistent uses of requesteeField vs requesteeField.parentNode (to get the <span> with the parens).  Straightened those out so the places that meant to get the <span> got the <span> and the places that meant to get the <input> got the <input>, and everything seems hunkydorey.

Comment 10

[Frédéric Buclin]

Yup! Works fine now. Thanks!