365339 - set cairo endianness macros in a sane way

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I fixed bug 364794 in a very hacky way to get Mac builds working again.  This is a bug to fix it properly.  In bug 364794 comment 7, I wrote:

I just checked in a hack fix to cairo-platform.h for this yesterday evening,
while bugzilla was down.

The basic problem is that nothing is responsible for defining any of
the endianness macros that cairo uses.  There's a standard autoconf
macro for WORDS_BIGENDIAN, but it makes cross-compilation harder for
some people doing a cross-compile (which includes universal builds
on Mac).  There's a custom autoconf macro in the cairo tree for
FLOAT_WORDS_BIGENDIAN.  Somehow cairo worked (enough) on Mac PPC
even though WORDS_BIGENDIAN was not defined, but the latest update
requires FLOAT_WORDS_BIGENDIAN to be correct for _cairo_lround.  Or
something like that -- I was debugging relatively quickly.

We could probably just make our cairo depend on prcpucfg.h, which
defines IS_BIG_ENDIAN.

But for now I checked in a really quick hack, since the Mac compiler
defines __BIG_ENDIAN__.

But we really need a long term solution for defining WORDS_BIGENDIAN
and FLOAT_WORDS_BIGENDIAN.

Comment 1

[Alfred Peng]

Attachment: Patch v1

The endian issue also exists in the SPARC platform for the MACRO isn't defined for it(Bug 367094). And it's a bug for all the BIG_ENDIAN platforms actually.

This patch goes with the choice to include prcpucfg.h.

Comment 2

[Alfred Peng]

The Firefox SPARC build is blocked by this issue. If we can fix it before the code freeze of Firefox 3.0a2, that will be great.

Ask for blocking1.9.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 253585 [details] [diff] [review]
Patch v1

Looks fine to me, thanks!

Comment 4

[Alfred Peng]

Checking in gfx/cairo/cairo/src/cairo-platform.h;
/cvsroot/mozilla/gfx/cairo/cairo/src/cairo-platform.h,v  <--  cairo-platform.h
new revision: 1.13; previous revision: 1.12
done

Comment 5

[Jeff Walden [:Waldo]]

Doesn't this patch want to be committed to gfx/cairo?