365367 - "@mozilla.org/consolemessage;1" not usable

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Ben Bucksch (:BenB)]

http://lxr.mozilla.org/seamonkey/source/xpcom/base/nsIConsoleMessage.idl#55
#define NS_CONSOLEMESSAGE_CONTRACTID "@mozilla.org/consolemessage;1"

This define is never used, not even to register the class, i.e. misleading.

XPCOM callers wouldn't be able to make use of the object, because the attribute message is readonly and init() does not exist (the C++ code is there, but commented out).
http://lxr.mozilla.org/seamonkey/source/xpcom/base/nsConsoleMessage.cpp#63

So, please either remove the define above, or actually make nsIConsoleMessage instantiatable and settable, so that JavaScript can generate console messages. I'd prefer the latter, given that the more complex nsIScriptError is creatable from JavaScript as well. I ran into the problem when I catched errors from C++ in JS and wanted to log them using Mozilla's logging API, in some JS utility function of my own.

Comment 1

[Ben Bucksch (:BenB)]

(In reply to comment #0)
> I'd prefer the latter, given that the more complex nsIScriptError is creatable
> from JavaScript as well. I ran into the problem when I catched errors from C++
> in JS and wanted to log them using Mozilla's logging API, in some JS utility
> function of my own.

Nevermind about that part, I realized I can use Components.utils.reportError().

Comment 2

[Carl X. Su]

Attachment: proposed patch

This is my first time to submit a bug.
I need someone to review my patch.

Comment 3

[Ben Bucksch (:BenB)]

Comment on attachment 717983 [details] [diff] [review]
proposed patch

Looks good to me

Not used: http://mxr.mozilla.org/comm-central/search?string=NS_CONSOLEMESSAGE_CONTRACTID

Comment 4

[Ben Bucksch (:BenB)]

Comment on attachment 717983 [details] [diff] [review]
proposed patch

bsmedberg is listed in whiteboard as mentor, and he's an XPCOM superreviewer, so I'll ask him for review.

Comment 5

[Josh Matthews [:jdm]]

Carl, for future reference the steps at https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in should help you create a patch that contains your author information and a commit message. That will allow somebody to commit your patch much easier.

Comment 6

[Carl X. Su]

Attachment: proposed patch (mq)

Thank you. I applied this patch with mq again.

Comment 7

[Josh Matthews [:jdm]]

I was about to push it with the amended message: Bug 365367 - NS_CONSOLEMESSAGE_CONTRACTID removed because it is never used. r=bsmedberg

But the tree was closed, so it will have to wait. Thanks for the fast turnaround!

Comment 8

[Josh Matthews [:jdm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/54d8c9723204

Comment 9

[Carl X. Su]

I pushed this patch to try server 1 hr ago.
Should I cancel it?

Comment 10

[Josh Matthews [:jdm]]

Yes. I'll do it while your LDAP password problems are sorted out.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/54d8c9723204