365457 - code-error/user-error should not use table to show error_message

Status: RESOLVED FIXED

(Bugzilla :: User Interface, enhancement)

Description

[victory <[e-mail]>]

code-error/user-error should not use table to show error_message.
this is NOT valid usage of table element and can be easily removed.

Comment 1

[victory <[e-mail]>]

Attachment: patch for tip

Comment 2

[timeless]

Comment on attachment 250256 [details] [diff] [review]
patch for tip

this loses the padding attribute (which can be mapped as css)

Comment 3

[victory <[e-mail]>]

Attachment: patch for tip v2

added 'padding: 20px;'

Comment 4

[Dave Miller [:justdave]]

oooh, one more skinnable item :)  (Something people are likely to want to skin, too)

Comment 5

[Frédéric Buclin]

Comment on attachment 250320 [details] [diff] [review]
patch for tip v2

This breaks the "Related documentation" feature on error pages. For instance, try accessing a restricted bug while you are logged out. The "Related documentation" box should not be included in the red area.

Comment 6

[victory <[e-mail]>]

Attachment: patch for tip v3

Comment 7

[Frédéric Buclin]

We are going to release 3.0 RC1 very soon now and this is not a bug.

Comment 8

[Frédéric Buclin]

Comment on attachment 250469 [details] [diff] [review]
patch for tip v3

>Index: global.css

>+    background: white;
>+    width: 28%;
> }

>+.error_message {
>+    background-color: red;
>+    color: black;
>+    font-size: x-large;
>+    padding: 2.5%;
>+    width: 65%;
>+}

The problem with this patch is that the width of the red box is always 65% of the window, even if there is no doc links to display. Also, the same width is used even if the error message is only a few words long.

Comment 9

[victory <[e-mail]>]

Comment on attachment 250469 [details] [diff] [review]
patch for tip v3

per #8

Comment 10

[Max Kanat-Alexander]

Bugzilla 3.2 is now frozen. Only enhancements blocking 3.2 or specifically approved for 3.2 may be checked in to the 3.2 branch. If you would like to nominate your enhancement for Bugzilla 3.2, set the "blocking3.2" flag to "?". Then, either the target milestone will be changed back, or the blocking3.2 flag will be granted, if we will accept this enhancement for Bugzilla 3.2.

This particular bug has not been touched in over eight months, and thus is being retargeted to "---" instead of "Bugzilla 4.0". If you believe this is a mistake, feel free to retarget it to Bugzilla 4.0.

Comment 11

[Frédéric Buclin]

This has been fixed by bug 920681 when we moved to HTML5.