Closed Bug 365907 Opened 18 years ago Closed 17 years ago

use spin controls for xul calendar

Categories

(Core Graveyard :: XForms, defect)

Product:
Core Graveyard
Component:
XForms
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: surkov, Assigned: surkov)

References

Details

(Keywords: fixed1.8.0.12, fixed1.8.1.4)

Attachments

(2 files, 2 obsolete files)

screenshot
61.02 KB, image/png
Details
patch3
22.49 KB, patch
aaronr
: review+
Details | Diff | Splinter Review 
Use spin controls for month/year fields of xhtml/xul calendars.
No longer blocks: 353880
Depends on: 353880
Blocks: 361997
Assignee: xforms → surkov.alexander
I'd like to do this for XUL calendar only right now.
Status: NEW → ASSIGNED
Summary: use spin controls for xhtml/xul calendars → use spin controls for xul calendar
Blocks: 368828
Attached patch patch (obsolete) — — Splinter Review 

        Attachment #253483 -
        Flags: review?(Olli.Pettay)

    
    

    
  
Olli, can you check whether bug 339080 is fixed by this bug?

    
    

    
  
(In reply to comment #3)
> Olli, can you check whether bug 339080 is fixed by this bug?
> 
Calendar looks almost ok. For some reason month field has a bit smaller
"scrollbar" than day field. Any reason for that?



    
    

    
  
(In reply to comment #4)
> (In reply to comment #3)
> > Olli, can you check whether bug 339080 is fixed by this bug?
> > 
> Calendar looks almost ok. For some reason month field has a bit smaller
> "scrollbar" than day field. Any reason for that?
> 
Not day, but year field.



    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch2 (obsolete)
        — 
          — Splinter Review
      

    


  
What about this?

        Attachment #253483 -
        Attachment is obsolete: true

        Attachment #254139 -
        Flags: review?(Olli.Pettay)

        Attachment #253483 -
        Flags: review?(Olli.Pettay)

    
  

        Attachment #254139 -
        Attachment mime type: application/octet-stream → text/plain

    
  

        Attachment #254139 -
        Attachment is patch: true

        Attachment #254139 -
        Flags: review?(Olli.Pettay) → review+

    
    

    
  
forgot to say that you have windows line endings in the patch.


    
    

    
  
Comment on attachment 254139 [details] [diff] [review]
patch2

(In reply to comment #8)
> forgot to say that you have windows line endings in the patch.
> 
I'll fix it after Aaron's comments

        Attachment #254139 -
        Flags: review?(aaronr)

    
    

    
  
Comment on attachment 254139 [details] [diff] [review]
patch2


>Index: extensions/xforms/resources/content/widgets-xul.xml
>===================================================================
>RCS file: /cvsroot/mozilla/extensions/xforms/resources/content/widgets-xul.xml,v
>retrieving revision 1.5
>diff -u -p -8 -r1.5 widgets-xul.xml
>--- extensions/xforms/resources/content/widgets-xul.xml	24 Jan 2007 19:54:42 -0000	1.5
>+++ extensions/xforms/resources/content/widgets-xul.xml	6 Feb 2007 08:26:00 -0000

>+  <!-- MONTHBOX -->
>+  <binding id="monthbox"
>+           extends="chrome://global/content/bindings/textbox.xml#textbox">
>+

>+      <method name="_modifyUp">
>+        <body>
>+          this.value++;
>+          this.fireEvent("spinup");
>+          this.fireEvent("change");
>+        </body>
>+      </method>
>+
>+      <method name="_modifyDown">
>+        <body>
>+          this.value--;
>+          this.fireEvent("spindown");
>+          this.fireEvent("change");
>+        </body>
>+      </method>

To be consistent, the change event should be fired before spinup or spindown.

>+
>+      <method name="fireEvent">
>+        <parameter name="aName"/>
>+        <body>
>+          var evt = document.createEvent("Events");
>+          evt.initEvent(aName, true, true);
>+          this.dispatchEvent(evt);
>+        </body>
>+      </method>
>+

To be consistent, spinup and spindown should not be cancelable.

I didn't find anything else.  r-'ing for now just to be sure that you'll be able to make those changes.

        Attachment #254139 -
        Flags: review?(aaronr) → review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch3
        — 
          — Splinter Review
      

    


  

        Attachment #254139 -
        Attachment is obsolete: true

        Attachment #254809 -
        Flags: review?(aaronr)

    
  

        Attachment #254809 -
        Flags: review?(aaronr) → review+

    
  
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED

    
    

    
  
checked in by ginn.
Whiteboard: xf-to-branch

    
    

    
  
checked into 1.8 branch on 2007-04-12
checked into 1.8.0 branch on 2007-04-16
Keywords: fixed1.8.0.12, 
          
            fixed1.8.1.4
Whiteboard: xf-to-branch
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: