Closed Bug 365996 Opened 18 years ago Closed 18 years ago

Take advantage of old yes/no constant in nsIPromptService

Categories

(Core :: General, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: csthomas, Assigned: sciguyryan)

References

()

Details

Attachments

(8 files, 1 obsolete file)

As part of bug 365529 I looked for callers not using stdyesno.  Almost every LXR result (see URL field) should be changed.
Product: Firefox → Core
QA Contact: general → general
OS: Windows XP → All
Hardware: PC → All
Assignee: nobody → bugs
Status: NEW → ASSIGNED
This patch contains changes too the following files:

* /toolkit/content/widgets/browser.xml
* /toolkit/components/passwordmgr/resources/content/passwordManager.js
Attachment #250568 - Flags: review?(gavin.sharp)
Attached patch Patches for browser (v1) (obsolete) — Splinter Review
This patch contains changes too the following files:

* /browser/base/content/browser.js
* /browser/components/preferences/main.js
Attachment #250569 - Flags: review?(gavin.sharp)
Attachment #250569 - Attachment is obsolete: true
Attachment #250569 - Flags: review?(gavin.sharp)
Corrected patch for browser.
Attachment #250570 - Flags: review?(gavin.sharp)
This patch contains changes too the following files:

* /mail/extensions/newsblog/content/feed-subscriptions.js
* /mail/extensions/smime/content/msgCompSMIMEOverlay.js
* /mail/components/preferences/viewpasswords.js
Attachment #250571 - Flags: superreview?(neil)
Attachment #250571 - Flags: review?(neil)
This patch contains changes too the following files:

* /xpfe/components/startup/src/nsAppStartup.cpp
* /xpfe/global/resources/content/bindings/browser.xml
Comment on attachment 250571 [details] [diff] [review]
Patches for mail (v1)

Sorry, I'm not a mail/ peer.
Attachment #250571 - Flags: superreview?(neil)
Attachment #250571 - Flags: review?(neil)
* /extensions/cck/browser/resources/content/cckwizard/cckwizard.js
* /extensions/wallet/signonviewer/resources/content/SignonViewer.js
* /mailnews/local/src/nsPop3Sink.cpp
* /mailnews/base/prefs/resources/content/am-smtp.js
* /mailnews/mapi/mapihook/src/nsMapiRegistry.cpp
* /mailnews/extensions/smime/resources/content/msgCompSMIMEOverlay.js

Sorry Neil, thought you were a peer for mail as well as mailnews :)
Attachment #250574 - Flags: superreview?(neil)
Attachment #250574 - Flags: review?(neil)
* /suite/common/search/search-panel.js
Attachment #250571 - Flags: superreview?(mscott)
Attachment #250571 - Flags: review?(mscott)
Attachment #250571 - Flags: superreview?(mscott)
Attachment #250571 - Flags: superreview+
Attachment #250571 - Flags: review?(mscott)
Attachment #250571 - Flags: review+
Attachment #250568 - Flags: review?(gavin.sharp) → review+
Attachment #250570 - Flags: review?(gavin.sharp) → review+
When all these patches are reviewed, can you attach a single diff so that I can land them all at once?
(In reply to comment #10)
> When all these patches are reviewed, can you attach a single diff so that I can
> land them all at once?
> 

Sure Gavin, no problem :) Can you suggest a reviewer for xpfe by any chance?
Attachment #250572 - Flags: superreview?(neil)
Attachment #250572 - Flags: review?(neil)
Attachment #250572 - Flags: superreview?(neil)
Attachment #250572 - Flags: superreview+
Attachment #250572 - Flags: review?(neil)
Attachment #250572 - Flags: review+
Comment on attachment 250574 [details] [diff] [review]
Patches for mailnews (v1)

Sorry for the delay, I didn't initially spot that one of the files was Windows-only so I had to retest.
Attachment #250574 - Flags: superreview?(neil)
Attachment #250574 - Flags: superreview+
Attachment #250574 - Flags: review?(neil)
Attachment #250574 - Flags: review+
Attached patch For CheckinSplinter Review
Patch requested by Gavin for checkin.
Whiteboard: [checkin needed]
toolkit/components/passwordmgr/resources/content/passwordManager.js 	1.16
toolkit/content/widgets/browser.xml 	1.99
browser/base/content/browser.js 	1.749
mail/components/preferences/viewpasswords.js 	1.4
mail/extensions/newsblog/content/feed-subscriptions.js 	1.17
mailnews/local/src/nsPop3Sink.cpp 	1.134
mailnews/extensions/smime/resources/content/msgCompSMIMEOverlay.js 	1.16
suite/common/search/search-panel.js 	1.88
mailnews/base/prefs/resources/content/am-smtp.js 	1.16
mailnews/mapi/mapihook/src/nsMapiRegistry.cpp 	1.18
xpfe/components/startup/src/nsAppStartup.cpp 	1.13
xpfe/global/resources/content/bindings/browser.xml 	1.50
extensions/wallet/signonviewer/resources/content/SignonViewer.js 	1.13
mail/extensions/smime/content/msgCompSMIMEOverlay.js 	1.4
extensions/cck/browser/resources/content/cckwizard/cckwizard.js 	1.56
browser/components/preferences/main.js 	1.8
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: