Closed
Bug 365996
Opened 18 years ago
Closed 18 years ago
Take advantage of old yes/no constant in nsIPromptService
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
People
(Reporter: csthomas, Assigned: sciguyryan)
References
()
Details
Attachments
(8 files, 1 obsolete file)
2.01 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
2.78 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
3.75 KB,
patch
|
mscott
:
review+
mscott
:
superreview+
|
Details | Diff | Splinter Review |
2.08 KB,
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
4.33 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
4.32 KB,
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
920 bytes,
patch
|
csthomas
:
review+
|
Details | Diff | Splinter Review |
20.17 KB,
patch
|
Details | Diff | Splinter Review |
As part of bug 365529 I looked for callers not using stdyesno. Almost every LXR result (see URL field) should be changed.
Reporter | ||
Updated•18 years ago
|
Product: Firefox → Core
QA Contact: general → general
Updated•18 years ago
|
OS: Windows XP → All
Hardware: PC → All
Assignee | ||
Updated•18 years ago
|
Assignee: nobody → bugs
Assignee | ||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•18 years ago
|
||
This patch contains changes too the following files: * /toolkit/content/widgets/browser.xml * /toolkit/components/passwordmgr/resources/content/passwordManager.js
Attachment #250568 -
Flags: review?(gavin.sharp)
Assignee | ||
Comment 2•18 years ago
|
||
This patch contains changes too the following files: * /browser/base/content/browser.js * /browser/components/preferences/main.js
Attachment #250569 -
Flags: review?(gavin.sharp)
Assignee | ||
Updated•18 years ago
|
Attachment #250569 -
Attachment is obsolete: true
Attachment #250569 -
Flags: review?(gavin.sharp)
Assignee | ||
Comment 3•18 years ago
|
||
Corrected patch for browser.
Attachment #250570 -
Flags: review?(gavin.sharp)
Assignee | ||
Comment 4•18 years ago
|
||
This patch contains changes too the following files: * /mail/extensions/newsblog/content/feed-subscriptions.js * /mail/extensions/smime/content/msgCompSMIMEOverlay.js * /mail/components/preferences/viewpasswords.js
Attachment #250571 -
Flags: superreview?(neil)
Attachment #250571 -
Flags: review?(neil)
Assignee | ||
Comment 5•18 years ago
|
||
This patch contains changes too the following files: * /xpfe/components/startup/src/nsAppStartup.cpp * /xpfe/global/resources/content/bindings/browser.xml
Comment 6•18 years ago
|
||
Comment on attachment 250571 [details] [diff] [review] Patches for mail (v1) Sorry, I'm not a mail/ peer.
Attachment #250571 -
Flags: superreview?(neil)
Attachment #250571 -
Flags: review?(neil)
Assignee | ||
Comment 7•18 years ago
|
||
* /extensions/cck/browser/resources/content/cckwizard/cckwizard.js * /extensions/wallet/signonviewer/resources/content/SignonViewer.js
Assignee | ||
Comment 8•18 years ago
|
||
* /mailnews/local/src/nsPop3Sink.cpp * /mailnews/base/prefs/resources/content/am-smtp.js * /mailnews/mapi/mapihook/src/nsMapiRegistry.cpp * /mailnews/extensions/smime/resources/content/msgCompSMIMEOverlay.js Sorry Neil, thought you were a peer for mail as well as mailnews :)
Attachment #250574 -
Flags: superreview?(neil)
Attachment #250574 -
Flags: review?(neil)
Assignee | ||
Comment 9•18 years ago
|
||
* /suite/common/search/search-panel.js
Assignee | ||
Updated•18 years ago
|
Attachment #250571 -
Flags: superreview?(mscott)
Attachment #250571 -
Flags: review?(mscott)
Reporter | ||
Updated•18 years ago
|
Attachment #250575 -
Flags: review+
Updated•18 years ago
|
Attachment #250571 -
Flags: superreview?(mscott)
Attachment #250571 -
Flags: superreview+
Attachment #250571 -
Flags: review?(mscott)
Attachment #250571 -
Flags: review+
Updated•18 years ago
|
Attachment #250568 -
Flags: review?(gavin.sharp) → review+
Updated•18 years ago
|
Attachment #250570 -
Flags: review?(gavin.sharp) → review+
Comment 10•18 years ago
|
||
When all these patches are reviewed, can you attach a single diff so that I can land them all at once?
Updated•18 years ago
|
Attachment #250573 -
Flags: review+
Assignee | ||
Comment 11•18 years ago
|
||
(In reply to comment #10) > When all these patches are reviewed, can you attach a single diff so that I can > land them all at once? > Sure Gavin, no problem :) Can you suggest a reviewer for xpfe by any chance?
Comment 12•18 years ago
|
||
I suggest Neil.
Assignee | ||
Updated•18 years ago
|
Attachment #250572 -
Flags: superreview?(neil)
Attachment #250572 -
Flags: review?(neil)
Updated•18 years ago
|
Attachment #250572 -
Flags: superreview?(neil)
Attachment #250572 -
Flags: superreview+
Attachment #250572 -
Flags: review?(neil)
Attachment #250572 -
Flags: review+
Comment 13•18 years ago
|
||
Comment on attachment 250574 [details] [diff] [review] Patches for mailnews (v1) Sorry for the delay, I didn't initially spot that one of the files was Windows-only so I had to retest.
Attachment #250574 -
Flags: superreview?(neil)
Attachment #250574 -
Flags: superreview+
Attachment #250574 -
Flags: review?(neil)
Attachment #250574 -
Flags: review+
Assignee | ||
Comment 14•18 years ago
|
||
Patch requested by Gavin for checkin.
Assignee | ||
Updated•18 years ago
|
Whiteboard: [checkin needed]
Comment 15•18 years ago
|
||
toolkit/components/passwordmgr/resources/content/passwordManager.js 1.16 toolkit/content/widgets/browser.xml 1.99 browser/base/content/browser.js 1.749 mail/components/preferences/viewpasswords.js 1.4 mail/extensions/newsblog/content/feed-subscriptions.js 1.17 mailnews/local/src/nsPop3Sink.cpp 1.134 mailnews/extensions/smime/resources/content/msgCompSMIMEOverlay.js 1.16 suite/common/search/search-panel.js 1.88 mailnews/base/prefs/resources/content/am-smtp.js 1.16 mailnews/mapi/mapihook/src/nsMapiRegistry.cpp 1.18 xpfe/components/startup/src/nsAppStartup.cpp 1.13 xpfe/global/resources/content/bindings/browser.xml 1.50 extensions/wallet/signonviewer/resources/content/SignonViewer.js 1.13 mail/extensions/smime/content/msgCompSMIMEOverlay.js 1.4 extensions/cck/browser/resources/content/cckwizard/cckwizard.js 1.56 browser/components/preferences/main.js 1.8
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
You need to log in
before you can comment on or make changes to this bug.
Description
•