366148 - Crashes in nsDocument::cycleCollection::Traverse

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Mark Knopper]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.9a2pre) Gecko/20070105 Camino/1.2+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.9a2pre) Gecko/20070105 Camino/1.2+

Camino trunk nightlies frequently crash in nsDocument::cycleCollection::Traverse(nsISupports*, nsCycleCollectionTraversalCallback&)

Reproducible: Sometimes

Steps to Reproduce:
1. Run Camino for a while. I was using Google Images to get iTunes album art.
2.
3.
Actual Results:  
See attached crash log.


PowerMac dual G5, Mac OS X 10.4.8

Comment 1

[Mark Knopper]

Attachment: Crash log

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Offhand, sounds like possible fallout from the XPCOM GC landing (bug 333078) yesterday (although there's a lovely non-virtual thunk to the appshell, too).

Comment 3

[Graydon Hoare :graydon]

I've committed a slightly more real fix -- still a band-aid -- to the culprit class nsImageDocument. Can you confirm that the bug is suppressed by this? 

Tracking the long-term problem back over in bug 333078.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I reproduced this bug on Windows too.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

talkback: TB28082183W

Comment 6

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #3)
> Tracking the long-term problem back over in bug 333078.

Just a suggestion: resolve the humongo "land cycle collector" bug (333078) now, since it is in fact landed, and file followup bugs (or use bugs like this one) for the remaining issues. You can mark them as blocking bug 333078 to link them to the major bug. It makes it much easier to identify specific issues without having to dig through a lot of comments/patches in one big bug, and "one issue per bug" especially helps when people are later trying to understand changes and why they were made.

Comment 7

[Mark Knopper]

I am no longer getting crashes with today's nightly trunk build.

Comment 8

[Graydon Hoare :graydon]

Fixed again -- more correctly -- with subsequent patch in 366063. Please reopen
if you are still seeing it.