366589 - Avoid places URIs parsing in the history sidebar as much as possible

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Asaf Romano (gone)]

We should not set gHistoryTree.place for every change in sort/grouping/search term in the history sidebar. Doing so is [supposed to be] slower than setting these options on the result/options objects. Once we fix that, we can also use OptionsFilter to persist the sidebar's mode.

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[(not reading, please use [e-mail] instead)]

Comment on attachment 251135 [details] [diff] [review]
patch

r=sspitzer

Comment 3

[(not reading, please use [e-mail] instead)]

dan will be interested in this clean up, for his work on the bookmarks sidebar.

Comment 4

[Asaf Romano (gone)]

mozilla/browser/components/places/content/history-panel.xul 1.5
mozilla/browser/components/places/content/history-panel.js 1.8

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv