Closed Bug 367236 Opened 17 years ago Closed 17 years ago

Build failed on Solaris for file gfxSkipChars.cpp

Categories

(Core :: Layout: Text and Fonts, defect)

Sun
OpenSolaris
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: alfred.peng, Assigned: alfred.peng)

Details

Attachments

(1 file)

"gfxSkipChars.cpp", line 109: Error: Overloading ambiguity between "std::abs(int)" and "std::abs(long)".

SunCC is stricter in type conversion than gcc.
Attached patch Patch v1Splinter Review
Explicit type conversion.
Assignee: nobody → alfred.peng
Status: NEW → ASSIGNED
Attachment #251770 - Flags: review?(roc)
actually, there's a bug here. The subtraction is done in unsigned space which is incorrect. I'll check in a fix that will also fix your build issues.
=>Fixed by Roc
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Attachment #251770 - Flags: review?(roc)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: