Closed
Bug 367239
Opened 18 years ago
Closed 18 years ago
use the same ID for SeaMonkey and thunderbird menubar
Categories
(SeaMonkey :: MailNews: Message Display, defect)
SeaMonkey
MailNews: Message Display
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kairo, Assigned: kairo)
References
()
Details
Attachments
(1 file)
|
4.17 KB,
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
In bug 313822, we realized that Lightning does not correctly overlay SeaMonkey's meilnews menubar just because Thunderbird has changed the ID of that bar for some reason and lightning is overlaying that one but not ours. The difference is actually as small as <menubar id="mailMenubar"> (SeaMonkey) vs. <menubar id="mail-menubar"> (Thunderbird). I propose that we pick up their ID, http://lxr.mozilla.org/mozilla/search?string=mailMenubar shows it being mentioned in only 3 files, and that would magically make Lightning work in suiterunner with my patch from bug 313822 (and make it easier for other extensions to support both apps).
|
Assignee | |
Comment 1•18 years ago
|
||
Here's the patch to change that ID to match with Thunderbird and therefore get lightning to overlay or menubar as well :)
Assignee: mail → kairo
Status: NEW → ASSIGNED
Attachment #251780 -
Flags: superreview?(neil)
Attachment #251780 -
Flags: review?(neil)
|
||
Updated•18 years ago
|
Attachment #251780 -
Flags: superreview?(neil)
Attachment #251780 -
Flags: superreview+
Attachment #251780 -
Flags: review?(neil)
Attachment #251780 -
Flags: review+
|
|
Assignee | |
Comment 2•18 years ago
|
||
checked in, thanks for the fast reviews!
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•