Closed
Bug 367719
Opened 18 years ago
Closed 18 years ago
xf:input for xul can't be readonly
Categories
(Core Graveyard :: XForms, defect)
Core Graveyard
XForms
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: surkov, Assigned: surkov)
References
()
Details
(Keywords: fixed1.8.0.12, fixed1.8.1.4)
Attachments
(2 files)
Assignee | ||
Comment 1•18 years ago
|
||
Attachment #252314 -
Flags: review?(aaronr)
Assignee | ||
Updated•18 years ago
|
Attachment #252314 -
Flags: review?(Olli.Pettay)
Assignee | ||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Updated•18 years ago
|
Attachment #252314 -
Flags: review?(Olli.Pettay) → review+
Comment on attachment 252314 [details] [diff] [review] patch from what I see in the code, the xhtml input sets the 'readonly' attribute directly on the xf:input, not on the underlying control. And it either sets the readonly attribute to the value 'readonly' or removes the attribute. The xhtml way sounds more correct to me, but either way, we need to be more consistent between the xhtml and xul implementation, I'd think.
Attachment #252314 -
Flags: review?(aaronr) → review-
Assignee | ||
Comment 3•18 years ago
|
||
(In reply to comment #2) > (From update of attachment 252314 [details] [diff] [review]) > from what I see in the code, the xhtml input sets the 'readonly' attribute > directly on the xf:input, not on the underlying control. We don't set 'readonly' for xf:input, we set it on html:input. > And it either sets > the readonly attribute to the value 'readonly' or removes the attribute. For XUL I set 'readonly' attribute for xul:textbox. XUL specifity is readonly attribute value has boolean type, i.e. 'readonly' value doesn't work properly. > The xhtml way sounds more correct to me That's interesting, please give more details :)
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 252314 [details] [diff] [review] [details]) > > from what I see in the code, the xhtml input sets the 'readonly' attribute > > directly on the xf:input, not on the underlying control. > > We don't set 'readonly' for xf:input, we set it on html:input. You are right, of course. Reading this cryptic JS hurts my head! r=me
Attachment #252314 -
Flags: review- → review+
Assignee | ||
Comment 5•18 years ago
|
||
needs to be checked in
Assignee | ||
Comment 7•18 years ago
|
||
checked in trunk by aaron
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
checked into 1.8 branch on 2007-04-12 checked into 1.8.0 branch on 2007-04-16
Keywords: fixed1.8.0.12,
fixed1.8.1.4
Whiteboard: xf-to-branch
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•