368418 - QuickLaunch - app startup pref ignored

Status: VERIFIED FIXED

(Core Graveyard :: QuickLaunch (AKA turbo mode), defect)

Description

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

In SM1.1., with QuickLaunch running, no matter what boxes are checked under Appearance->"When SeaMonkey starts up, open", a shortcut that runs seamonkey.exe with no arguments results in a browser only.

Comment 1

[[e-mail]]

Attachment: Proposed patch

OK, so the issue here is that seamonkey -turbo needs to inhibit the default preferences. It does this by setting an mShouldShowUI flag to false, but this flag never gets set to true again. This wasn't a problem in 1.0.x because bug 58523 changed the order of startup tests and this code only used to run once.

Comment 3

[[e-mail]]

Comment on attachment 255587 [details] [diff] [review]
Proposed patch

See previous comment...

Comment 4

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 255587 [details] [diff] [review]
Proposed patch

I think this fixed bug 368421 too.

Comment 5

[Wayne Mery (:wsmwk)]

suspect there is _at least_ one, much older dupe. sorry, i read quite of few but don't have number(s)

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 255587 [details] [diff] [review]
Proposed patch

could you diff with more context and -p in the future?

Comment 11

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Any reason this bug isn't marked as resolved?

Comment 12

[[e-mail]]

(In reply to comment #11)
>Any reason this bug isn't marked as resolved?
Because I was checking with KaiRo as to whether it would make 1.1.1 and overlooked that he'd only set the 1.1.1 flag and not resolved it too.

Comment 13

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Verifying based on user feedback.