368859 - large sharp variable numbers are silently rounded down

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[shutdown]

Attachment: use the appropriate limit

Without the patch:

$ dbg.obj/js -e "print(function(){ return #65535#, #65536#; });"
function () {
    return #65535#, #0#;
}

With the patch:

$ dbg.obj/js -e "print(function(){ return #65535#, #65536#; });"
-e:1: SyntaxError: overlarge sharp variable number:
-e:1: print(function(){ return #65535#, #65536#; });
-e:1: ..................................^

Comment 1

[Brendan Eich [:brendan]]

Comment on attachment 253494 [details] [diff] [review]
use the appropriate limit

Yikes! Why'd I couple to the wrong limit (no atom index [JOF_CONST format] ops for sharp var numbers, they're 16-bit [JOF_UINT16]).

Thanks for patching this, I will check it in now.

/be

Comment 2

[Brendan Eich [:brendan]]

Safe rider for patch releases.

js/src/jsscan.c 3.119

Patch I landed in a sec, for posterity.

/be

Comment 3

[Brendan Eich [:brendan]]

Attachment: use UINT16_LIMIT from jsopcode.h

Pedantic, but I figured it might help future opcode format readers and revisers.

/be

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 255286 [details] [diff] [review]
use UINT16_LIMIT from jsopcode.h

This is the one that should ride along.

/be

Comment 5

[Bob Clary [:bc] (inactive)]

/cvsroot/mozilla/js/tests/js1_5/extensions/regress-368859.js,v  <--  regress-368859.js

Comment 6

[Bob Clary [:bc] (inactive)]

verified fixed 20070217 1.9.0 windows/mac*/linux

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 255286 [details] [diff] [review]
use UINT16_LIMIT from jsopcode.h

approved for 1.8/1.8.0 branches, a=dveditz for drivers

Comment 8

[Brian Crowder]

Landed on branches:

1.8   - jsscan.c: 3.81.2.28
1.8.0 - jsscan.c: 3.81.2.7.2.10

Comment 9

[Brian Crowder]

For 1.8.0, we don't have the UINT16_LIMIT define, so I am just using ((uintN)1 << 16) directly.

jsscan.c: 3.81.2.7.2.11

Comment 10

[Bob Clary [:bc] (inactive)]

verified fixed windows, macppc, linux 1.8.0, 1.8.1 20070420 shell.