369012 - split client name and version number into separate query params

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, enhancement)

Description

[Tony Chang (Google)]

For logging reasons, it's easier if we have the client name and the app version in separate query parameters when making update and lookup requests.

Comment 1

[Tony Chang (Google)]

Attachment: split {moz:client} and {moz:version}

Specifically, this changes the update url to be
update?client=Firefox&appver=2.0.0.1&
or
update?client=navclient-auto-ffox&appver=2.0.0.1&

And it changes the lookup url to be 
lookup?client=Firefox&appver=2.0.0.1&
or
lookup?client=navclient-auto-ffox&appver=2.0.0.1&

Comment 2

[Marria Nazif]

Comment on attachment 253676 [details] [diff] [review]
split {moz:client} and {moz:version}

Looks good to me

Comment 3

[Tony Chang (Google)]

On trunk.

Checking in app/profile/firefox.js;
/cvsroot/mozilla/browser/app/profile/firefox.js,v  <--  firefox.js
new revision: 1.169; previous revision: 1.168
done
Checking in components/safebrowsing/content/globalstore.js;
/cvsroot/mozilla/browser/components/safebrowsing/content/globalstore.js,v  <--  globalstore.js
new revision: 1.15; previous revision: 1.14
done

Comment 4

[Daniel Veditz [:dveditz]]

Blocking to keep on the radar for now.

How is the trunk version working? Happy with the patch? Does the server back-end handle getting two different formats (new and old) at the same time?

Comment 5

[Tony Chang (Google)]

(In reply to comment #4)
> How is the trunk version working? Happy with the patch? Does the server
> back-end handle getting two different formats (new and old) at the same time?

The server handles both (new and old) formats.  It's working fine on trunk right now.

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 253676 [details] [diff] [review]
split {moz:client} and {moz:version}

approved for 1.8.1.4, a=dveditz for release-drivers

Comment 7

[Tony Chang (Google)]

on branch

Checking in app/profile/firefox.js;
/cvsroot/mozilla/browser/app/profile/firefox.js,v  <--  firefox.js
new revision: 1.71.2.82; previous revision: 1.71.2.81
done
Checking in components/safebrowsing/content/globalstore.js;
/cvsroot/mozilla/browser/components/safebrowsing/content/globalstore.js,v  <--  globalstore.js
new revision: 1.1.2.11; previous revision: 1.1.2.10
done

Comment 8

[juan becerra [:juanb]]

Verified on: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.4pre) Gecko/20070506 BonEcho/2.0.0.4pre

Used livehttpheaders and searched for update and lookup urls which now look like:

http://sb.google.com/safebrowsing/update?client=navclient-auto-ffox&appver=2.0.0.4pre...

http://sb.google.com/safebrowsing/lookup?sourceid=firefox-antiphish&features=TrustRank&client=navclient-auto-ffox&appver=2.0.0.4pre...