Closed
Bug 369126
Opened 18 years ago
Closed 17 years ago
[FIX]"ASSERTION: A frame but no DOM element!?" removing a <frame> whose onunload handler tries to load another page
Categories
(Core :: DOM: Navigation, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: bzbarsky)
References
Details
(Keywords: assertion, testcase)
Attachments
(2 files)
|
395 bytes,
text/html
|
Details | |
|
1018 bytes,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
Loading the testcase triggers: ###!!! ASSERTION: A frame but no DOM element!?: 'requestingElement', file /Users/jruderman/trunk/mozilla/docshell/base/nsDocShell.cpp, line 6212
|
Assignee | |
Comment 1•18 years ago
|
||
I should note that this makes the location set throw in this testcase. I suppose I could just return NS_OK, but this seems more correct.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #253795 -
Flags: superreview?(jst)
Attachment #253795 -
Flags: review?(jst)
|
Reporter | |
Comment 2•18 years ago
|
||
It currently throws NS_ERROR_FAILURE, so making it throw something else shouldn't be a problem.
|
|
Assignee | |
Updated•18 years ago
|
Summary: "ASSERTION: A frame but no DOM element!?" removing a <frame> whose onunload handler tries to load another page → [FIX]"ASSERTION: A frame but no DOM element!?" removing a <frame> whose onunload handler tries to load another page
|
||
Comment 3•17 years ago
|
||
Comment on attachment 253795 [details] [diff] [review] Fix r+sr=jst
Attachment #253795 -
Flags: superreview?(jst)
Attachment #253795 -
Flags: superreview+
Attachment #253795 -
Flags: review?(jst)
Attachment #253795 -
Flags: review+
|
|
Assignee | |
Comment 4•17 years ago
|
||
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 6•16 years ago
|
||
See also bug 443655, where a new testcase triggers the same assertion as this FIXED bug.
You need to log in
before you can comment on or make changes to this bug.
Description
•