Closed Bug 369388 Opened 17 years ago Closed 17 years ago

Profile Manager has a "Start Mozilla" button

Categories

(SeaMonkey :: Startup & Profiles, defect)

1.8 Branch
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: glandium, Assigned: glandium)

Details

(Keywords: fixed-seamonkey1.1.7, fixed-seamonkey1.1.8)

Attachments

(1 file)

(this was originally reported on debian for iceape displaying "Start Debian")

The profile manager dialog has a "Start Mozilla" button which should read "Start Seamonkey".
Attachment #254060 - Flags: review?(ajvincent)
Comment on attachment 254060 [details] [diff] [review]
Patch for the issue

I'm not a reviewer for profile manager.  Neil is (and fortunately is also a super-reviewer).  For trivial patches like this, it's usually best to seek r and sr and the same time.
Attachment #254060 - Flags: superreview?(neil)
Attachment #254060 - Flags: review?(neil)
Attachment #254060 - Flags: review?(ajvincent)
WFM with
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.13pre) Gecko/20070612 SeaMonkey/1.0.9
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.5pre) Gecko/20070611 SeaMonkey/1.1.2
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a6pre) Gecko/2007061901 SeaMonkey/2.0a1pre
(In reply to comment #2)
> WFM with
> Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.13pre) Gecko/20070612
> SeaMonkey/1.0.9
> Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.5pre) Gecko/20070611
> SeaMonkey/1.1.2
> Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a6pre) Gecko/2007061901
> SeaMonkey/2.0a1pre

Mmmmm interesting... vendorShortName is SeaMonkey where it should be Mozilla in brand.dtd...
Looks like this has been fixed already on the trunk.
Assignee: nobody → mh+mozilla
Comment on attachment 254060 [details] [diff] [review]
Patch for the issue

Yes, this was effectively fixed on trunk when we switched to using toolkit's version of that entity (which had the same effect as this patch).
Attachment #254060 - Flags: superreview?(neil)
Attachment #254060 - Flags: superreview+
Attachment #254060 - Flags: review?(neil)
Attachment #254060 - Flags: review+
Attachment #254060 - Flags: approval-seamonkey1.1.6?
Comment on attachment 254060 [details] [diff] [review]
Patch for the issue

sounds good for 1.1.6, thanks! a=me
Attachment #254060 - Flags: approval-seamonkey1.1.6? → approval-seamonkey1.1.6+
I'll try to check this in soon. What's the branch name I should use?
Keywords: checkin-needed
Checking in profile/resources/locale/en-US/profileSelection.dtd;
/cvsroot/mozilla/profile/resources/locale/en-US/Attic/profileSelection.dtd,v  <--  profileSelection.dtd
new revision: 1.17.24.1; previous revision: 1.17
done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: