Closed
Bug 369411
Opened 18 years ago
Closed 14 years ago
improve CRC error value
Categories
(Toolkit :: Application Update, defect)
Toolkit
Application Update
Tracking
()
RESOLVED
FIXED
mozilla2.0b9
People
(Reporter: moco, Assigned: robert.strong.bugs)
References
()
Details
Attachments
(1 file)
751 bytes,
patch
|
Dolske
:
review+
rcampbell
:
feedback+
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
improve CRC error value right now, we do: 777 // Verify that the contents of the source file correspond to what we expect. 778 779 unsigned int crc = crc32(buf, header.slen); 780 781 if (crc != header.scrc32) { 782 LOG(("CRC check failed\n")); 783 return CRC_ERROR; 784 } 785 we could at least log the two crc values.
Reporter | ||
Comment 1•18 years ago
|
||
this would be useful in tracking down the automation failure that rob and rob are seeing. my wild $1 guess says that header src is 0.
Updated•16 years ago
|
Product: Firefox → Toolkit
Assignee | ||
Comment 2•14 years ago
|
||
Sample output: LoadSourceFile: destination file crc -1141869618 does not match expected crc -2130395286
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #498573 -
Flags: review?(dolske)
Comment 3•14 years ago
|
||
Comment on attachment 498573 [details] [diff] [review] patch rev 1 looks good to me.
Attachment #498573 -
Flags: feedback+
Assignee | ||
Comment 4•14 years ago
|
||
Comment on attachment 498573 [details] [diff] [review] patch rev 1 Dave, simple patch that improves diagnosing update problems. Thought you might be able to give a quick r and a +
Attachment #498573 -
Flags: review?(dolske) → review?(dtownsend)
Updated•14 years ago
|
Attachment #498573 -
Flags: review?(dtownsend) → review+
Assignee | ||
Updated•14 years ago
|
Attachment #498573 -
Flags: approval2.0?
Updated•14 years ago
|
Attachment #498573 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Comment 5•14 years ago
|
||
Pushed to mozilla-central http://hg.mozilla.org/mozilla-central/rev/19df7ba36bc4
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9
You need to log in
before you can comment on or make changes to this bug.
Description
•