369451 - When setting default browser first clean up HKCU keys

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Robert Strong (they/them - no direct email)]

We need this to properly set the default app when it was set under HKCU previously and the user is given admin rights.

Comment 1

[(not reading, please use [e-mail] instead)]

this fixed on the branch, but not trunk yet.

robert is forward porting the fix to the trunk

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 254133 [details] [diff] [review]
patch

r=sspitzer

Comment 4

[Robert Strong (they/them - no direct email)]

I'll land this on the trunk after it re-opens

Comment 5

[Robert Strong (they/them - no direct email)]

Checked in to trunk

Comment 6

[Jay Patel [:jay]]

rstrong/seth:  I was trying to verify this bug, but could not get anything to create keys in HKCU.  What would normally create the keys there that we want to clean up?

Comment 7

[Robert Strong (they/them - no direct email)]

For the purposes of verification you could set them manually. Alternatively, on WinXP as admin you could set IE as the default browser, as a regular user set Firefox as the default browser (this should create the keys under HKCU), grant the regular user admin rights, change the default value under HKCU Software\Classes\http\shell\open\command, and then set Firefox as the default browser.

Comment 8

[Robert Strong (they/them - no direct email)]

btw: this will only remove the values which is the minimum necessary. We will add the ability to remove empty keys as part of bug 369770.

Comment 9

[Jay Patel [:jay]]

(In reply to comment #8)
> btw: this will only remove the values which is the minimum necessary. We will
> add the ability to remove empty keys as part of bug 369770.
> 

In that case, I already verified this by adding my own keys and values as you suggested, where the values were removed when setting Firefox to default.  I just got confused when the keys remained (and were even taken over by IE if I switched the default back).

v.fixed with Firefox 2.0.0.2 rc2.