36958 - installer requires reboot

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Description

[Cathleen]

1) download 4/23/2000 installer from sweetlou
   ftp://sweetlou/products/client/5.0x/windows/32bit/x86/2000-04-23-16-M16/
2) run installer
3) select a new directory to install into
4) at the end of install, reboot dialog comes up, asking for permission to 
   restart.


Sean and I looked at the install log, and found that 

\defaults\profile\panels.rdf is getting installed by both browser.xpi and 
mail.xpi.  The second install from mail.xpi caused a replace of the first 
install.  This normally shouldn't be a problem, and should not require a reboot 
because the file is not in use.

Comment 1

[Sean Su]

fixed.

The problem was in nsLocalFileMac.cpp and nsLocalFileWin.cpp.  The ::Exists() 
function was caching what it found ealier.  So when the file was renamed from 
underneath it, it didn't know to look skip the cache.

So all I did was call MakeDirty() right before the function that performed the 
actual checking.  This forced it to invalidate the cache.

I assume this was also happening on the mac because it was calling the same set 
of functions as under Windows.  Mac should also be fixed.

Comment 2

[Jimmy Lee]

Build: 2000-05-09-09-M16(WIN), 2000-05-09-08-M16(MAC), 2000-05-09-08-M16(WIN)

No more reboot dialogs.  Marking Verified!