Closed
Bug 36968
Opened 24 years ago
Closed 24 years ago
PROFILE should use nsIFile
Categories
(Core Graveyard :: Profile: BackEnd, defect, P3)
Core Graveyard
Profile: BackEnd
Tracking
(Not tracked)
VERIFIED
FIXED
M17
People
(Reporter: dougt, Assigned: ccarlen)
Details
(Whiteboard: [nsbeta2-] [nsbeta3+])
Profile should use nsIFile. nsFileSpec is unsupported. In processArgs nsFileSpec::nsFileSpec() line 828 + 34 bytes nsProfile::ProcessArgs(nsICmdLineService * 0x01060e60, int * 0x0012fe18, nsCString & {...}) line 422 nsProfile::StartupWithArgs(nsProfile * const 0x00d38d30, nsICmdLineService * 0x01060e60) line 233 + 20 bytes main1(int 0x00000001, char * * 0x00c44a60, nsISplashScreen * 0x00000000) line 711 + 41 bytes main(int 0x00000001, char * * 0x00c44a60) line 968 + 17 bytes mainCRTStartup() line 338 + 17 bytes KERNEL32! 77f1ba06() also, there is a static nsFileSpec which is not used: static nsFileSpec sRedundantDirectory;
Comment 1•24 years ago
|
||
Doug, what is the external symptom of this bug? How do I reproduce it?
Reporter | ||
Comment 2•24 years ago
|
||
there is no external symptom. if you do find one, and it turn out to be nsFileSpec related, you will be on your own. nsIFile and nsILocalFile is the one true way.
Updated•24 years ago
|
Assignee: selmer → racham
Comment 3•24 years ago
|
||
Bhuvan, if this is a lot of effort let me know. This should not come before ANY feature work unless it's actually broken with no workaround.
nsFileSpec has been used extensively in the profile module. Yes. nsIFile should be the way to go. We need to do the switch carefully and make sure no regressions pop up. I will not pursue this before any of the feature. Let's keep this in M16 now. I may be able to get to this.
Status: NEW → ASSIGNED
Target Milestone: --- → M16
Putting on [nsbeta2-] radar. Come back to us when you have a user aware symptom OR set to nsbeta3 keyword.
Whiteboard: [nsbeta2-]
Comment 8•24 years ago
|
||
Bhuvan, how ya doing? Shouldn't this go to the Future bucket?
This is one of the important things that we want to do for beta3. It will help us with lot of i18n issues too...
Keywords: correctness,
nsbeta3
Comment 10•24 years ago
|
||
I am reassigning this to Conrad. He is doing as part of his DirectoryService and appfilelocprovider efforts.
Assignee: racham → ccarlen
Status: ASSIGNED → NEW
Assignee | ||
Comment 11•24 years ago
|
||
I've got this taken care of - Changes are in hand and awaiting checkin. I've tested thoroughly on Mac. I could use some more testing on other platforms.
Status: NEW → ASSIGNED
Comment 12•24 years ago
|
||
Send the whole list of your patches. I can help you with testing..
Updated•24 years ago
|
Whiteboard: [nsbeta2-] → [nsbeta2-] [nsbeta3+]
Assignee | ||
Comment 13•24 years ago
|
||
Changes checked in. Verify by searching nsIProfile.idl and nsProfile.h for methods taking nsFileSpec or nsIFileSpec.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•