370101 - getfunns does not call SAVE_SP_AND_PC

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Igor Bukanov]

JSOP_GETFUNNS does not call SAVE_SP_AND_PC before calling js_GetFunctionNamespace. The latter on the first initialization of function:: namespace can call JS_InitClass for namespace and qname classes which uses the stack for the constructor call. In that the unsaved portion of the stack will be nuked. I was hit by that while developing fixes for bug 370016, bug 370048 and bug  369740. 

But without a fix for bugs I was not able to come up so far with a test case to show the bug. With code like:
  with(Math)
    print(function::sin)
the function::sin triggers not found function exception. That in turn throws away the damaged portion of the stack. But the bug should be visible in the js debugger.

Comment 1

[Igor Bukanov]

Attachment: Fix v1

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 254759 [details] [diff] [review]
Fix v1

r=me, d'oh.

/be

Comment 3

[Igor Bukanov]

I committed the patch from comment 1 to the trunk:

Checking in jsinterp.c;
/cvsroot/mozilla/js/src/jsinterp.c,v  <--  jsinterp.c
new revision: 3.328; previous revision: 3.327
done

Comment 4

[Igor Bukanov]

Nominating for branches this very safe fix. 

Comment 5

[Igor Bukanov]

Attachment: 1.8.1 version of fix v

Comment 6

[Igor Bukanov]

Attachment: 1.8.0 version of fix v

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 254960 [details] [diff] [review]
1.8.1 version of fix v

approved for 1.8/1.8.0 branches, a=dveditz for drivers

Comment 8

[Igor Bukanov]

I committed the patch from comment 5 to MOZILLA_1_8_BRANCH:

Checking in jsinterp.c;
/cvsroot/mozilla/js/src/jsinterp.c,v  <--  jsinterp.c
new revision: 3.181.2.85; previous revision: 3.181.2.84
done

Comment 9

[Igor Bukanov]

I committed the patch from comment 6 to MOZILLA_1_8_0_BRANCH:

Checking in jsinterp.c;
/cvsroot/mozilla/js/src/jsinterp.c,v  <--  jsinterp.c
new revision: 3.181.2.17.2.30; previous revision: 3.181.2.17.2.29
done