Closed
Bug 370243
Opened 17 years ago
Closed 17 years ago
XULRunner dmg no longer contains installer
Categories
(Toolkit Graveyard :: XULRunner, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jhpedemonte, Assigned: jhpedemonte)
Details
(Keywords: fixed1.8.0.12, fixed1.8.1.4)
Attachments
(1 file)
|
1.74 KB,
patch
|
benjamin
:
first-review+
dveditz
:
approval1.8.1.4+
dveditz
:
approval1.8.0.12+
|
Details | Diff | Splinter Review |
Normally, the XULRunner/Mac package is distributed as a disk image that contains an installer. This seems to have been broken by the fix to bug 359687. Now, the disk image contains a XULRunner folder which must be manually installed by the user. Patch is attached. Gavin, not sure if you are the right person to ask for review during bsmedberg's absence.
Attachment #254906 -
Flags: first-review?(gavin.sharp)
|
Assignee | |
Updated•17 years ago
|
Assignee: nobody → jhpedemonte
|
||
Comment 1•17 years ago
|
||
Comment on attachment 254906 [details] [diff] [review] patch Sorry for not mentioning this earlier, but I don't know this code well enough to review it. I believe Benjamin is back from his leave now, though.
Attachment #254906 -
Flags: first-review?(gavin.sharp)
|
|
Assignee | |
Updated•17 years ago
|
Attachment #254906 -
Flags: first-review?(benjamin)
|
||
Updated•17 years ago
|
Attachment #254906 -
Flags: first-review?(benjamin) → first-review+
|
|
Assignee | |
Comment 2•17 years ago
|
||
Checked in to trunk. -> FIXED
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 3•17 years ago
|
||
Comment on attachment 254906 [details] [diff] [review] patch Bug 359687 broke this for the two 1.8 branches, so it would be good to fix it there also.
Attachment #254906 -
Flags: approval1.8.1.3?
Attachment #254906 -
Flags: approval1.8.0.11?
|
||
Comment 4•17 years ago
|
||
Comment on attachment 254906 [details] [diff] [review] patch approved for 1.8.0.12 and 1.8.1.4, a=dveditz for release-drivers
Attachment #254906 -
Flags: approval1.8.1.4?
Attachment #254906 -
Flags: approval1.8.1.4+
Attachment #254906 -
Flags: approval1.8.0.12?
Attachment #254906 -
Flags: approval1.8.0.12+
|
|
Assignee | |
Comment 5•17 years ago
|
||
Checked in to both 1.8 branches.
Keywords: fixed1.8.0.12,
fixed1.8.1.4
|
||
Updated•8 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•