Closed Bug 370582 Opened 17 years ago Closed 17 years ago

"Minefield Safe Mode" context menu on windows start menu internet shortcut is broken

Categories

(Firefox :: Shell Integration, defect)

Product:
Firefox
Component:
Shell Integration
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: fullmetaljacket.xp+bugmail, Assigned: robert.strong.bugs)

Details

(Keywords: verified1.8.1.4)

Attachments

(1 file)

patch
1.30 KB, patch
moco
: review+
dveditz
: approval1.8.1.4+
Details | Diff | Splinter Review 
when minefield is set as the default browser on windows, it can launch by clicking the "Internet" shortcut on windows start menu (appears on the top left of the xp styled start menu).

that "Internet" shortcut had a context menu entry that says "Minefield Safe Mode" which should launch minefield in safe mode but it appears to be broken.

problem can be reproduced using current nightly on windows xp and vista.
Severity: normal → major
btw, it was broken in the sense that it still launch minefield in normal mode (with default profile)


Considering there is a simple workaround by using the shortcut in the start menu this is by no means major. :P
Severity: major → normal
Attached patch patch — — Splinter Review 
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED

        Attachment #255295 -
        Flags: review?(sspitzer)
Flags: blocking1.8.1.3?

    
    

    
  
Comment on attachment 255295 [details] [diff] [review]
patch

r=sspitzer

        Attachment #255295 -
        Flags: review?(sspitzer) → review+

    
    

    
  
Fixed on trunk
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED

    
    

    
  
wow that was quick. thanks!

marking it VERIFIED using

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a3pre) Gecko/20070215 Minefield/3.0a3pre ID:2007021519 [cairo]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a3pre) Gecko/20070215 Minefield/3.0a3pre ID:2007021519 [cairo]
Status: RESOLVED → VERIFIED

    
    

    
  
Are you going to fix that on the 1.8 branch as well? You requested blocking, but not approval.

    
    

    
  
yes, still waiting on 1.8.1.2 to make it out the door

        Attachment #255295 -
        Flags: approval1.8.1.3?
Severity: normal → trivial
Flags: blocking1.8.1.4? → blocking1.8.1.4+

        Attachment #255295 -
        Flags: approval1.8.1.3? → approval1.8.1.4?

    
    

    
  
Comment on attachment 255295 [details] [diff] [review]
patch

approved for 1.8.1.4, a=dveditz for release-drivers

        Attachment #255295 -
        Flags: approval1.8.1.4? → approval1.8.1.4+

    
    

    
  
Checked in to MOZILLA_1_8_BRANCH
Keywords: fixed1.8.1.4

    
    

    
  
verified fixed on 1.8.1.4 using  Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4pre) Gecko/2007043003 BonEcho/2.0.0.4pre - the Safe Mode Shortcut is working like expected -> adding verified keyword
Keywords: fixed1.8.1.4 → verified1.8.1.4

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: