370614 - New download URLs make saving extensions difficult

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Wladimir Palant]

Go to some extension page, right-click on "Install now" and choose "Save link target as". The suggested file name will be something like 12345.htm - it should be extension_name-version.xpi instead. At the very least it should be done with the Content-Disposition HTTP header.

Comment 1

[Andrei Hajdukewycz [:sancus]]

Content-disposition has no effect on Save Link As, as far as I can tell, so that's pretty useless. However, we will have a "Download" button in place of the install button for Thunderbird add-ons that will use Content-Disposition attachment, and may add one for non-tb add-ons.

The only way I can see to fix this is by tacking the filename onto the end of the url even if it doesn't mean anything to Remora.

Comment 2

[Fred Wenzel [:wenzel]]

Yes, the content-disposition header might indeed help: http://us2.php.net/header (search for content-disposition). Doesn't this suggest the right filename for the downloaded file?

However if you choose to implement this, make sure it doesn't break the regular installations. :)

Comment 3

[Wladimir Palant]

(In reply to comment #1)
> Content-disposition has no effect on Save Link As, as far as I can tell, so
> that's pretty useless.

Tested this, you are right.

> The only way I can see to fix this is by tacking the filename onto the end of
> the url even if it doesn't mean anything to Remora.

Exactly.

Comment 4

[Cameron]

Re. content disposition headers - Bug 299372

Comment 6

[Andrei Hajdukewycz [:sancus]]

I added a trailing filename to all the download urls, which should deal with this.

Comment 7

[James Ross]

V.FIXED on preview.addons.mozilla.org.

Comment 8

[Oliver Saier]

I'm still seeing this on http://preview.addons.mozilla.org/en-US/thunderbird/addon/878 (login required)

Comment 9

[Justin Scott [:fligtar]]

Looks like the sandbox install needs the filename appended as well.

Comment 10

[Andrei Hajdukewycz [:sancus]]

It has it appended, and works in the test data. Not really sure what's going on here on preview. Going to have to get the full data dump to debug this.

Comment 11

[Christian Höltje]

There is a problem with sanitizing the URLs as well, see bug #372302 which fixed +, but other chars, like ' are being left in.

Ciao!

Comment 12

[Thomas Bertels]

This doesn't seem to be reproducible anymore, does it ?

Comment 13

[Wladimir Palant]

Yes, I think this can be marked fixed again.

Comment 14

[Fred Wenzel [:wenzel]]

So be it, thanks.