370794 - [FIX]"ASSERTION: used padding property missing (out of memory?)" with overflow: hidden and position: fixed

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

###!!! ASSERTION: used padding property missing (out of memory?): 'p', file /Users/jruderman/trunk/mozilla/layout/generic/nsFrame.cpp, line 764

This is the same assertion that showed up in bug 366952, which dbaron fixed.

Comment 1

[Jesse Ruderman]

Attachment: testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: I think this is the way to go

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Who's passing in an |aPadding| without overriding nsIFrame::GetUsedPadding?

Comment 4

[Boris Zbarsky [:bzbarsky]]

nsHTMLScrollFrame::ReflowScrolledFrame.

I'm not sure how easy it is to override it, since there are so many different things the scrolled frame could be.  I suppose we could just put that in the nsFrame GetUsedPadding or something....

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

::-moz-scrolled-content already has padding:inherit, so I'm not even sure why that code is needed.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Because inheriting a percentage does the wrong thing -- it computes the percentage using the scrollframe as the containing block.  See the blame for that Init() call in nsHTMLScrollFrame::ReflowScrolledFrame.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

ok, r+sr=dbaron

Comment 8

[Boris Zbarsky [:bzbarsky]]

Hmm.  Though I guess this means that all table rows, etc, will end up with these props, even though they don't need them.  Maybe I should put this code in nsGfxScrollFrame instead?

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

That would work -- especially if you set the property before the reflow state is constructed, since there could be a GetUsedPadding call later in the nsHTMLReflowState constructor.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Attachment: Do that

Comment 11

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 12

[Jesse Ruderman]

Crashtest checked in.