370967 - Crash when focusing the input of an isindex and then reloading the document

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase:
- Focus the text input of the isindex element
- Reload the document

Result: crash
It doesn't happen always, just try it another time, it happens fairly often.

This regressed between 2007-02-18 and 2007-02-19:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-02-18+05&maxdate=2007-02-19+09&cvsroot=%2Fcvsroot
My guess is a regression from bug 257868 since that patch is touching isindex files.

Comment 1

[Martijn Wargers (dead)]

But I guess this might be a regression from bug 368549, instead.

Comment 2

[Peter Van der Beken [:peterv]]

I locally backed out the fixes for bug 368549 and for bug 367779 and I can still reproduce this.

Comment 3

[Peter Van der Beken [:peterv]]

Backing out the patch from bug 257868 fixes this for me.

Comment 4

[Nickolay_Ponomarev]

Now that I null out mInputContent in nsIsIndexFrame::Destroy, the event listener is not destroyed in the destructor.

Interestingly, I can't create an auto-test for this, since it doesn't appear to be possible to focus the isindex from a script (?). I could use some help with this.

Comment 5

[Nickolay_Ponomarev]

Attachment: patch

Comment 6

[Nickolay_Ponomarev]

Attachment: patch

Comment 7

[Nickolay_Ponomarev]

mozilla/layout/forms/nsIsIndexFrame.cpp 1.87

Comment 8

[Mats Palmgren (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0bb00fdf5447

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0bb00fdf5447