371653 - crash in [@ nsMsgAccountManager::GetIncomingServer] when getPrefService has not been called

Status: RESOLVED FIXED

(MailNews Core :: Account Manager, defect)

Description

[arno renevier]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.1) Gecko/20061205 Iceweasel/2.0.0.1 (Debian-2.0.0.1+dfsg-2)
Build Identifier: version 3 alpha 1 (20070225)

If nsMsgAccountManager::GetIncomingServer is called, but m_pref is null, 
rv = m_prefs->GetCharPref(serverPref.get(), getter_Copies(serverType));
makes thunderbird crash
This can happen if you have an application shipped as an extension for thunderbird (application which you call with thunderbird -chrome chrome://blabla/content), and first line of your script is for example:

Components.classes["@mozilla.org/messenger/account-manager;1"].
        createInstance(Components.interfaces.nsIMsgAccountManager).
        getIncomingServer('server1');

I've attached a .xpi for testcase.

My suggestion is to add a call to nsMsgAccountManager::getPrefService in nsMsgAccountManager::GetIncomingServer.
I'll attach this solution as a patch.

Reproducible: Always

Steps to Reproduce:
1. install .xpi at http://ffsearchplugins.free.fr/bugzilla/nsimsgaccountmanager-crash.xpi
2. start thunderbird with thunderbird -chrome chrome://crash/content/crash.xul
Actual Results:  
crash

Expected Results:  
no crash

Comment 1

[arno renevier]

Attachment: call getPrefService in nsMsgAccountManager::GetIncomingServer

Comment 2

[arno renevier]

Another possibility would be to call getPrefService once in nsMsgAccountManager constructor instead of calling it in each method that needs it. That ensures we don't have the same problem on other methods. Are there any drawbacks ?

Comment 3

[timeless]

it can fail and constructors have no way of indicating failure.

so you can be right back where you started. if you don't mind crashing again next time, then it doesn't have any drawbacks...

Comment 4

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

The .xpi can no longer be accessed.

Bienvenu, any thoughts on this? (not sure on the validity of this..)

Comment 5

[Mark Banner (:standard8)]

The bug is essentially still valid. Given nsMsgAccountManager is a service and has an Init function, I would suggest that the pref service is initialised once in the Init function, and the getPrefService function is dropped.

Comment 6

[Wayne Mery (:wsmwk)]

(no crashes in last 9 months)

Comment 7

[:aceman]

Should the same (comment 5) be done in nsMsgAccount.cpp too? It seems the only file using similar approach.

Comment 8

[:aceman]

Attachment: patch per comment 5

Standard8, did you mean something like this?

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 590849 [details] [diff] [review]
patch per comment 5

Review of attachment 590849 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/src/nsMsgAccountManager.cpp
@@ +1273,5 @@
> +   * to add to the existing accounts list.
> +   */
> +  nsCOMPtr<nsIPrefBranch> defaultsPrefBranch;
> +  rv = prefservice->GetDefaultBranch(MAILNEWS_ROOT_PREF, getter_AddRefs(defaultsPrefBranch));
> +  NS_ENSURE_SUCCESS(rv,rv);

nit: as you're touching these lines, please insert a space after the comma (several places in this section)

Comment 10

[:aceman]

Attachment: patch with nit

With review from standard8.

Comment 11

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/e0ccaae60f48