371669 - Cannot drop or paste items from the history sidebar into the bookmarks toolbar

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Asaf Romano (gone)]

Cannot drop or paste items from the history sidebar into the bookmarks toolbar (in places bookmarks builds).

Comment 1

[Dietrich Ayala (:dietrich)]

Attachment: fix v1

Comment 2

[Asaf Romano (gone)]

Comment on attachment 256588 [details] [diff] [review]
fix v1

r=mano with a comment either here or inlined in tree.xml on the ip check.

I was thinking of separating this into a new type (TYPE_X_MOZ_PLACES_BOOKMARK?) when we get back to d&d code cleanup.

Comment 3

[Dietrich Ayala (:dietrich)]

(In reply to comment #2)
> (From update of attachment 256588 [details] [diff] [review])
> r=mano with a comment either here or inlined in tree.xml on the ip check.

I added a comment in tree.xml.

> I was thinking of separating this into a new type (TYPE_X_MOZ_PLACES_BOOKMARK?)
> when we get back to d&d code cleanup.
> 

Sounds like a good idea, better to be explicit about the transfer types.

Checking in tree.xml;
/cvsroot/mozilla/browser/components/places/content/tree.xml,v  <--  tree.xml
new revision: 1.56; previous revision: 1.55
done
Checking in utils.js;
/cvsroot/mozilla/browser/components/places/content/utils.js,v  <--  utils.js
new revision: 1.14; previous revision: 1.13
done

Comment 4

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv