371792 - JS Error when opening .EML file

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Mike Cowperthwaite]

Bug 358121 fixed a similar problem by adding a try/catch around the line
  folder = aUrl.folder;
but the line immediately after includes a test for null 'folder' before testing for the foldertype being 'nntp' or 'rss' -- because 'folder' is null, when you open a .EML file.

Bug 328749 replaced that code with a rewrite; the analogous try/catch block was maintained in the new code, but the null-folder check was not.  This is now causing an error every time you open a .EML file.  That's what this bug is about.


Bug 358247 ported the 358121 code to Seamonkey and put the test within the try block, allowing the null check to be discarded.  Seamonkey is still running with the older code.  (Is it really necessary that this file is forked?)

Comment 1

[Mike Cowperthwaite]

xref bug 358121 comment 5

Comment 2

[Mike Cowperthwaite]

Attachment: diff -uw vs. 2b2-0221 distro

This fixes the problem by moving the test inside the try block, per Neil's comment.  This fixes the bug and re-allows the .EML file to be detected as a scam, altho the "Not a Scam" button does nothing when clicked in that case.  Maybe it should be disabled.

Comment 3

[Mike Cowperthwaite]

Attachment: diff -u

Sorry, I'm an idiot; you don't need a whitespace patch here.

Comment 4

[Scott MacGregor]

Comment on attachment 256490 [details] [diff] [review]
diff -u  

thanks Mike.

Comment 5

[Mike Cowperthwaite]

V with TB 2.0pre-0227, Win2K.